Re: [GIT PULL 0/4] perf/annotate loop detection V2, fixes

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Fri, Apr 27, 2012 at 05:48:57PM +0200, Peter Zijlstra escreveu:
> On Fri, 2012-04-27 at 12:31 -0300, Arnaldo Carvalho de Melo wrote:
> > Yeah, there are some unused graphical chars. But perhaps we should just
> > use ↓ again?
> > 
> >      0.00 │┌─→ c0:    cmp    %rax,%rbx
> >      0.00 ││          mov    %rax,%rcx
> >      0.00 ││      ↓   ↓je    5dd
> >      0.00 ││   cc:    test   %rcx,%rcx
> >      0.00 ││      ↓   ↓je    da
> >      0.00 ││          mov    0x8(%rcx),%esi
> >      0.00 ││          shr    $0x4,%esi
> >      0.00 ││          sub    $0x2,%esi
> >      0.00 ││   da:    mov    %rcx,0x10(%rbx)
> >      0.00 ││          mov    %rcx,%rax
> >      0.00 ││          cmpl   $0x0,%fs:0x18
> >      0.00 ││      ↓   ↓je    ed
> >      0.00 ││          lock   cmpxchg %rbx,(%rdx)
> >      0.00 ││          cmp    %rax,%rcx
> >           ││
> >      0.00 │└──────↑ } jne    c0
> > 
> > Does it still stands out? I think so, we expect a letter there,
> > something very different is there, matching the other down arrowsome
> > columns to the left. 
> 
> That just looks daft.. what's wrong with the single up/down arrow?

Yeah, that too, or perhaps we can bring the instruction column closer to
the jump column and then that makes it stand out better?
 
> Also, can we keep all this on the list please?

 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: 8bit

Is doing the trick with keeping the arrows, etc, readable here, I'll
check what is wrong with git-send-email that corrupted the messages when
I tried using it to post patches.

- Arnaldo