From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>,
ShuoX Liu <shuox.liu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] percpu, x86: don't use PMD_SIZE as embedded atom_size on 32bit
Date: Fri, 27 Apr 2012 10:27:01 -0700 [thread overview]
Message-ID: <20120427172701.GC26595@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204271219320.32270@router.home>
On Fri, Apr 27, 2012 at 12:21:34PM -0500, Christoph Lameter wrote:
> On Fri, 27 Apr 2012, Tejun Heo wrote:
>
> > This patch makes x86_32 always use PAGE_SIZE as atom_size for embed
> > first chunk allocator.
>
> Would it not be easier to use the first #ifdef in the function to set
> pcpu_chosen_fc = PCPU_FC_PAGE?
>
> You could just skip the whole PCPU_FC_PAGE block in the CONFIG_X86_32
> case.
PCPU_FC_PAGE != PCPU_FC_EMBED w/ PAGE_SIZE atom_size. EMBED still
gets to piggy back on the kernel linear mapping for the first chunk
unlike PAGE. It apparently created noticeable difference (I'm
guessing due to extra TLB pressure) for intel android folks.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-04-27 17:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 8:49 [PATCH] mm: percpu: Add PCPU_FC_FIXED to pcpu_fc for setting fixed pcpu_atom_size ShuoX Liu
2012-04-25 22:24 ` Tejun Heo
2012-04-26 2:01 ` Yanmin Zhang
2012-04-26 22:49 ` Tejun Heo
2012-04-27 1:09 ` Yanmin Zhang
2012-04-27 8:56 ` Yanmin Zhang
2012-04-27 16:53 ` [PATCH] percpu, x86: don't use PMD_SIZE as embedded atom_size on 32bit Tejun Heo
2012-04-27 17:17 ` H. Peter Anvin
2012-04-27 17:27 ` Tejun Heo
2012-04-27 17:21 ` Christoph Lameter
2012-04-27 17:27 ` Tejun Heo [this message]
2012-04-27 17:39 ` [PATCH v2] " Tejun Heo
2012-04-27 17:51 ` H. Peter Anvin
2012-04-27 17:53 ` Tejun Heo
2012-04-28 2:18 ` [PATCH] " ShuoX Liu
2012-04-27 16:34 ` [PATCH] mm: percpu: Add PCPU_FC_FIXED to pcpu_fc for setting fixed pcpu_atom_size Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427172701.GC26595@google.com \
--to=tj@kernel.org \
--cc=cl@linux.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shuox.liu@intel.com \
--cc=tglx@linutronix.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox