Re: [PATCH 2/2] asm-generic: io: don't perform swab during {in,out} string functions

Mike Frysinger
2012-04-27T17:24:35Z

[-- Attachment #1: Type: Text/Plain, Size: 1018 bytes --]

On Friday 27 April 2012 12:59:19 Will Deacon wrote:
> On Fri, Apr 27, 2012 at 05:18:58PM +0100, Mike Frysinger wrote:
> > On Friday 27 April 2012 06:42:56 Will Deacon wrote:
> > > The {in,out}s{b,w,l} functions are designed to operate on a stream of
> > > bytes and therefore should not perform any byte-swapping, regardless of
> > > the CPU byte order.
> >
> > says who ? where's the agreed upon documentation for this ?
>
> This specific case is actually documented in Linux Device Drivers

if it isn't in the tree (either Documentation/ or in asm-generic/io.h itself),
i don't think it's acceptable to refer to it as guiding documentation

> appreciate that it's not especially clear. I had some offline discussion
> with Arnd where we agreed on this -- it also means that asm-generic/io.h
> matches what is done by bi-endian architectures providing their own
> accessors.

please add start adding comments above these functions that clearly spell out
the expectations and behavior
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]