public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Kevin Hilman <khilman@ti.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	markgross@thegnar.org, Jean Pihet <j-pihet@ti.com>
Subject: [PATCH 0/3] PM / QoS / Domains: Fixes and optimization, take 2
Date: Sun, 29 Apr 2012 03:08:52 +0200	[thread overview]
Message-ID: <201204290308.52416.rjw@sisk.pl> (raw)
In-Reply-To: <201204272346.44145.rjw@sisk.pl>

Hi all,

On Friday, April 27, 2012, Rafael J. Wysocki wrote:
> 
> This series is on top of the PM domains governor functions fixup patches
> posted recently:
> 
> http://marc.info/?l=linux-pm&m=133538218801804&w=4
> http://marc.info/?l=linux-pm&m=133538220601826&w=4
> http://marc.info/?l=linux-pm&m=133538218801805&w=4
> 
> Patch [1/2] is a fix that I think should be applied anyway.  Patch [2/2],
> though, is an RFC.  It is a bit subtle, although perhaps that's not immediately
> visible at first sight.  Patch [2/2] hasn't been tested yet, but I have
> verified that it builds.

As it has happened to me for a couple of times recently, unfortunately,
I found a couple of issues with patch [2/2].

Most importantly, I forgot about the adaptive adjustments of device and domain
latency numbers, which obviously had to be taken into consideration in that
patch.  Also, it turned out during testig that there was a locking issue
in pm_genpd_remove_device() that wasn't very easy to address.  In the end,
I had to use an additional patch to help that, which is the current [2/3].

So, [1/3] is the previous [1/2] (with the Mark's ACK).  [2/3] is a new patch,
which is a pm_genpd_remove_device() cleanup that may be regarded as a fix too
and [3/3] is the one that makes the default PM domain governors cache their
results if possible (that's even more subtle than before, but hopefully
I didn't break anything this time).

Thanks,
Rafael


  parent reply	other threads:[~2012-04-29  1:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 21:46 [PATCH 0/2] PM / QoS / Domains: Fix and optimization Rafael J. Wysocki
2012-04-27 21:48 ` [PATCH 1/2] PM / QoS: Create device constraints objects on notifier registration Rafael J. Wysocki
2012-04-28 15:33   ` mark gross
2012-04-28 21:10     ` Rafael J. Wysocki
2012-04-27 21:53 ` [PATCH 2/2][RFC] PM / Domains: Cache device stop and domain power off governor results Rafael J. Wysocki
2012-04-29  1:08 ` Rafael J. Wysocki [this message]
2012-04-29  1:11   ` [PATCH 1/3] PM / QoS: Create device constraints objects on notifier registration Rafael J. Wysocki
2012-04-30  8:57     ` Jean Pihet
2012-04-29  1:12   ` [PATCH 2/3] PM / Domains: Make device removal more straightforward Rafael J. Wysocki
2012-04-29  1:14   ` [PATCH 3/3][RFC] PM / Domains: Cache device stop and domain power off governor results, v2 Rafael J. Wysocki
2012-04-29 14:12     ` [Update][PATCH 3/3][RFC] PM / Domains: Cache device stop and domain power off governor results, v3 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204290308.52416.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=j-pihet@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=markgross@thegnar.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox