From: Gleb Natapov <gleb@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: avi@redhat.com, mtosatti@redhat.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] KVM: Emulator: Opcode 0x80 gets a byte immediate
Date: Sun, 29 Apr 2012 11:22:33 +0300 [thread overview]
Message-ID: <20120429082233.GX15413@redhat.com> (raw)
In-Reply-To: <1335536616-8524-1-git-send-email-namit@cs.technion.ac.il>
On Fri, Apr 27, 2012 at 05:23:36PM +0300, Nadav Amit wrote:
> The single byte opcode 0x80 should get a byte immediate.
> The previous emulation is broken for opcode 0x80.
It is not. That what ByteOp is about.
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 8375622..dd53e53 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3464,7 +3464,7 @@ static struct opcode opcode_table[256] = {
> /* 0x70 - 0x7F */
> X16(D(SrcImmByte)),
> /* 0x80 - 0x87 */
> - G(ByteOp | DstMem | SrcImm | ModRM | Group, group1),
> + G(ByteOp | DstMem | SrcImmByte | ModRM | Group, group1),
> G(DstMem | SrcImm | ModRM | Group, group1),
> G(ByteOp | DstMem | SrcImm | ModRM | No64 | Group, group1),
> G(DstMem | SrcImmByte | ModRM | Group, group1),
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Gleb.
prev parent reply other threads:[~2012-04-29 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 14:23 [PATCH] KVM: Emulator: Opcode 0x80 gets a byte immediate Nadav Amit
2012-04-29 8:22 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120429082233.GX15413@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=namit@cs.technion.ac.il \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox