From: Andi Shyti <andi.shyti@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/02] fixed coding style issue with comments
Date: Sun, 29 Apr 2012 16:59:07 +0200 [thread overview]
Message-ID: <20120429145907.GB3536@andi> (raw)
In-Reply-To: <20120429132014.GA3435@debian.Jeff>
Hi,
On Sun, Apr 29, 2012 at 06:50:14PM +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to comments
[...]
> if (crate != rate) {
> snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
> - // runtime->rate = crate;
> + /* runtime->rate = crate; */
> }
If you really want ti fix some style issues, you could also split
the snd_printd() line that is over 80 characters.
Moreover, this comment is not really meaningful, I would remove
it at all.
I would prefer something like
- if (create != rate) {
+ if (create != rate)
- snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
+ snd_printd(KERN_WARNING
+ "current rate %d is different from runtime rate %d\n",
+ crate, rate);
- // runtime->rate = crate;
- }
Andi
prev parent reply other threads:[~2012-04-29 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 13:20 [PATCH 01/02] fixed coding style issue with comments Jeffrin Jose
2012-04-29 14:59 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120429145907.GB3536@andi \
--to=andi.shyti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox