From: Greg KH <greg@kroah.com>
To: Markus Franke <markus.franke@s2002.tu-chemnitz.de>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100
Date: Sun, 29 Apr 2012 22:13:00 -0400 [thread overview]
Message-ID: <20120430021300.GA18148@kroah.com> (raw)
On Thu, Apr 12, 2012 at 12:40:30AM +0200, Markus Franke wrote:
> This patch adds a 1-wire slave device driver for the DS28E04-100.
>
> Signed-off-by: Markus Franke <franm@hrz.tu-chemnitz.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Andrew asked me to relook at this patch, and it turns out to be pretty
messy, I should have never applid it.
You have a lot of checkpatch warnings and errors, and you are creating
new sysfs files with no documentation at all as to what you are doing,
and why you are doing it. sysfs binary files at that, which should not
be used by ANY code that is trying to intrepret the data being sent to
those files, sysfs binary files are for "pass-through" mode only.
So please redo this patch, cleaning up all of the warnings and errors,
and use the standard kernel interfaces for this type of stuff (i.e. not
sysfs binary files.)
I've reverted it from my tree now, sorry.
greg k-h
next reply other threads:[~2012-04-30 5:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 2:13 Greg KH [this message]
2012-05-02 20:12 ` [PATCH] w1: Add 1-wire slave device driver for DS28E04-100 Markus Franke
2012-05-02 20:21 ` Greg KH
2012-05-03 18:00 ` Evgeniy Polyakov
2012-05-09 20:37 ` Markus Franke
2012-05-09 22:06 ` Greg KH
2012-05-09 22:16 ` Markus Franke
2012-05-09 22:24 ` Greg KH
2012-05-09 22:37 ` Markus Franke
2012-05-09 23:57 ` Evgeniy Polyakov
2012-05-10 0:01 ` Greg KH
2012-05-10 0:43 ` Evgeniy Polyakov
2012-05-10 3:43 ` Greg KH
2012-05-10 4:55 ` Markus Franke
2012-05-10 15:16 ` Greg KH
2012-05-10 22:57 ` Markus Franke
2012-05-10 23:04 ` Greg KH
2012-05-11 6:13 ` Markus Franke
2012-05-15 1:21 ` Evgeniy Polyakov
2012-05-25 22:45 ` Markus Franke
2012-05-10 23:22 ` Andrew Morton
2012-05-11 6:15 ` Markus Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430021300.GA18148@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.franke@s2002.tu-chemnitz.de \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox