From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: linux-kernel@vger.kernel.org, Anthony.Olech@diasemi.com
Subject: Re: [PATCH] Regmap: Converts group operation into single read write operations
Date: Mon, 30 Apr 2012 23:29:17 +0100 [thread overview]
Message-ID: <20120430222916.GA5604@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1335767746.9546.15.camel@dhruva>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Mon, Apr 30, 2012 at 12:05:46PM +0530, Ashish Jangam wrote:
> Some devices does not support bulk read and write operations, for them
> we have series of single write and read operations.
Applied, though please in future
- Use a changelog that matches the subsystem
- Follow the kernel coding style, you should use
I fixed both these things up, and also...
> + if (config->use_single_rw)
> + map->use_single_rw = config->use_single_rw;
There's no need to check if the flag is set here, you can just assign
directly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-30 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 6:35 [PATCH] Regmap: Converts group operation into single read write operations Ashish Jangam
2012-04-30 22:29 ` Mark Brown [this message]
2012-04-30 22:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430222916.GA5604@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Anthony.Olech@diasemi.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox