public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jonghwa3.lee@samsung.com
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
	cw00.choi@samsung.com, Chiwoong byun <woong.byun@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH] MFD : add MAX77686 mfd driver
Date: Wed, 2 May 2012 09:52:21 +0100	[thread overview]
Message-ID: <20120502085220.GC4075@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FA0BF9C.7090107@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Wed, May 02, 2012 at 02:01:16PM +0900, jonghwa3.lee@samsung.com wrote:
> Hi Mark,
> 
> You point out many things. ;-) Thanks for your concern.
> I want to explain one by one.

Don't top post!  http://daringfireball.net/2007/07/on_top

> 2. Those steps is needed for wake-up interrupt occurred by 77686 irq.
>    When system has woken up from Suspend-to-RAM state by 77686 irq,
> 	then it never call irq handler.

Why?  Are you sure you aren't doing something like requesting the wrong
trigger type for the interrupt?

> 4. This will work when I2C interface is changed according to board
> 	revision with board configuration.

> 5. This is for some board that doesn't use RTC. (e.g. SMDK board)

Since you top posted I'm really not sure which comments you're referring
to with these...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-05-02  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30  8:53 [PATCH] MFD : add MAX77686 mfd driver Jonghwa Lee
2012-04-30  9:17 ` Andi Shyti
2012-05-02  5:02   ` jonghwa3.lee
2012-05-02  9:28     ` Andi Shyti
2012-05-01 16:58 ` Mark Brown
2012-05-02  5:01   ` jonghwa3.lee
2012-05-02  8:52     ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-30  8:57 함명주

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502085220.GC4075@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonghwa3.lee@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    --cc=woong.byun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox