From: NeilBrown <neilb@suse.de>
To: John Stultz <johnstul@us.ibm.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>,
Felipe Balbi <balbi@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>,
"Bergmann, Arnd" <arnd@arndb.de>
Subject: Re: omap-usb-host.c compile error
Date: Wed, 2 May 2012 09:29:56 +1000 [thread overview]
Message-ID: <20120502092956.3277750a@notabene.brown> (raw)
In-Reply-To: <4FA056A1.1040209@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
On Tue, 01 May 2012 14:33:21 -0700 John Stultz <johnstul@us.ibm.com> wrote:
>
> I've been seeing the following compile issue for a few -rcs now:
> drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'cpu_is_omap3430'
> drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function
> 'omap_rev'
> drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared
> (first use in this function)
> drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is
> reported only once
> drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)
>
> Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
>
> This still isn't fixed in Linus' HEAD. Any plans here?
>
> thanks
> -john
Following fixes it for me.
NeilBrown
Author: NeilBrown <neilb@suse.de>
Date: Wed Apr 25 10:52:05 2012 +1000
omap-usb-host: add include plat/cpu.h
Need this for a version comparison.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index c8aae66..7da9496 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -26,6 +26,7 @@
#include <linux/dma-mapping.h>
#include <linux/spinlock.h>
#include <plat/usb.h>
+#include <plat/cpu.h>
#include <linux/pm_runtime.h>
#define USBHS_DRIVER_NAME "usbhs_omap"
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-05-01 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 21:33 omap-usb-host.c compile error John Stultz
2012-05-01 23:29 ` Nicolas Dechesne
2012-05-01 23:29 ` NeilBrown [this message]
2012-05-02 7:46 ` Samuel Ortiz
2012-05-02 17:46 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502092956.3277750a@notabene.brown \
--to=neilb@suse.de \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=johnstul@us.ibm.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox