From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: mingo@kernel.org, pjt@google.com, suresh.b.siddha@intel.com,
efault@gmx.de, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/5] sched, fair: Let minimally loaded cpu balance the group
Date: Wed, 2 May 2012 15:55:41 +0530 [thread overview]
Message-ID: <20120502102541.GA22740@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120501182610.745844312@chello.nl>
* Peter Zijlstra <a.p.zijlstra@chello.nl> [2012-05-01 20:14:31]:
> @@ -3795,12 +3796,11 @@ static inline void update_sg_lb_stats(st
>
> /* Bias balancing toward cpus of our domain */
> if (local_group) {
> - if (idle_cpu(i) && !first_idle_cpu) {
> - first_idle_cpu = 1;
> + load = target_load(i, load_idx);
> + if (load < balance_load || idle_cpu(i)) {
> + balance_load = load;
Let's say load_idx != 0 (ex: a busy cpu doing this load balance). In
that case, for a idle cpu, we could return non-zero load and hence this
would fail to select such a idle cpu? IOW :
balance_load = 0 iff idle_cpu(i) ??
> balance_cpu = i;
> }
> -
> - load = target_load(i, load_idx);
> } else {
> load = source_load(i, load_idx);
> if (load > max_cpu_load) {
>
>
- vatsa
next prev parent reply other threads:[~2012-05-02 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 18:14 [RFC][PATCH 0/5] various sched and numa bits Peter Zijlstra
2012-05-01 18:14 ` [RFC][PATCH 1/5] sched, fair: Let minimally loaded cpu balance the group Peter Zijlstra
2012-05-02 10:25 ` Srivatsa Vaddagiri [this message]
2012-05-02 10:31 ` Peter Zijlstra
2012-05-02 10:34 ` Srivatsa Vaddagiri
2012-05-04 0:05 ` Suresh Siddha
2012-05-04 16:09 ` Peter Zijlstra
2012-05-01 18:14 ` [RFC][PATCH 2/5] sched, fair: Add some serialization to the sched_domain load-balance walk Peter Zijlstra
2012-05-01 18:14 ` [RFC][PATCH 3/5] x86: Allow specifying node_distance() for numa=fake Peter Zijlstra
2012-05-01 18:14 ` [RFC][PATCH 4/5] x86: Hard partition cpu topology masks on node boundaries Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502102541.GA22740@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox