Re: [PATCH] Cleanup page-type.c

[Fengguang Wu <fengguang.wu@intel.com>]

On Wed, May 02, 2012 at 02:19:01PM -0400, KOSAKI Motohiro wrote:
> (5/2/12 10:41 AM), Ulrich Drepper wrote:
> > Compiling page-type.c with a recent compiler produces many warnings,
> > mostly related to signed/unsigned comparisons.  This patch cleans up
> > most of them.
> > 
> > One remaining warning is about an unused parameter.  The<compiler.h>
> > file doesn't define a __unused macro (or the like) yet.  This can be
> > addressed later.
> > 
> > The line numbers for this patch correspond to the file changed to remove
> > the duplicate definitions of the KPF_* macros which is contained in
> > another patch.  It should apply cleanly albeit with warnings even without
> > that patch applied first.
> > 
> > 
> > Signed-off-by: Ulrich Drepper<drepper@gmail.com>
> > 
> >   page-types.c |   22 +++++++++++-----------
> >   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> Looks good to me.
>  Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Acked-by: Fengguang Wu <fengguang.wu@intel.com>

> offtopic:
> Wu, I have (unrelated) one question. page-type is used from production
> systems nowadays. Why don't you want to move page-type.c into tools/ dir?

I was actually thinking the same with you, and the good news is, it's
recently moved into tools/ by Dave Young:

commit c6dd897f3bfc54a44942d742d6dfa842e33d88e0
Author: Dave Young <dyoung@redhat.com>
Date:   Wed Mar 28 14:42:55 2012 -0700

    mm: move page-types.c from Documentation to tools/vm

Thanks,
Fengguang