From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Davidson <md@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
Date: Thu, 3 May 2012 15:12:00 -0700 [thread overview]
Message-ID: <20120503221200.GA22903@kroah.com> (raw)
In-Reply-To: <20120503220747.7B1E88095E@fiasco.mtv.corp.google.com>
On Thu, May 03, 2012 at 03:07:47PM -0700, Michael Davidson wrote:
> [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
>
> DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
> not device_show_ulong() and device_store_ulong()
>
> Signed-off-by: Michael Davidson <md@google.com>
> ---
>
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -508,7 +508,7 @@ ssize_t device_store_int(struct device *
> { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
> #define DEVICE_INT_ATTR(_name, _mode, _var) struct dev_ext_attribute dev_attr_##_name = - { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
> + { __ATTR(_name, _mode, device_show_int, device_store_int), &(_var) }
Something odd happened with your patch, and I can't apply it :(
Care to try again?
next prev parent reply other threads:[~2012-05-03 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 22:07 [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions Michael Davidson
2012-05-03 22:12 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-03 23:19 Michael Davidson
2012-05-03 23:32 ` Greg KH
2012-05-03 23:39 ` Michael Davidson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503221200.GA22903@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox