From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, abbotti@mev.co.uk,
fmhess@users.sourceforge.net
Subject: Re: [PATCH] staging: comedi: remove debug tracing in vmk80xx driver
Date: Fri, 4 May 2012 11:50:12 -0700 [thread overview]
Message-ID: <20120504185012.GA11426@kroah.com> (raw)
In-Reply-To: <201205041123.55261.hartleys@visionengravers.com>
On Fri, May 04, 2012 at 11:23:54AM -0700, H Hartley Sweeten wrote:
> The vmk80xx driver uses a non-existant Kconfig symbol to enable
> function call debug tracing. This output is really just noise
> and doesn't serve any useful purpose. Remove all it's uses in
> the driver.
Nice.
Really, all tracing should be removed from pretty much all drivers, as
we have good built-in tracing tools in the kernel now, so rolling your
own is not needed.
thanks,
greg k-h
prev parent reply other threads:[~2012-05-04 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:23 [PATCH] staging: comedi: remove debug tracing in vmk80xx driver H Hartley Sweeten
2012-05-04 18:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504185012.GA11426@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox