From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Cc: Paul Bolle <pebolle@tiscali.nl>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: also announce bcdDevice
Date: Sat, 5 May 2012 07:52:24 -0700 [thread overview]
Message-ID: <20120505145224.GA27469@kroah.com> (raw)
In-Reply-To: <4FA519B3.9030901@fold.natur.cuni.cz>
On Sat, May 05, 2012 at 02:14:43PM +0200, Martin Mokrejs wrote:
> Paul Bolle wrote:
> > Currently announce_device() does print the idVendor and idProduct values
> > but does not print the bcdDevice value. USB devices are accurately
> > identified by all three values. See, for instance, the USB storage
> > quirks which will only apply for a certain (range of) bcdDevice
> > value(s). So it seems useful to also print bcdDevice when announcing USB
> > devices.
>
> Could it also report negotiated speed? full-speed, high-speed, super-speed?
All of this, including the bcdDevice, can be found in sysfs. So I don't
want to take this patch, otherwise we would be just adding more and more
to the kernel log.
If you programatically want to find this out, use libudev or listen to
the dbus messages for new devices, don't watch the kernel log messages.
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-05 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 11:51 [PATCH] usb: also announce bcdDevice Paul Bolle
2012-05-05 12:14 ` Martin Mokrejs
2012-05-05 14:52 ` Greg Kroah-Hartman [this message]
2012-05-05 15:09 ` Martin Mokrejs
2012-05-05 15:28 ` Alan Stern
2012-05-05 17:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120505145224.GA27469@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mmokrejs@fold.natur.cuni.cz \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox