From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Nikolaus Voss <n.voss@weinmann.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/power/sbs-battery.c: capacity attr = remaining relative capacity
Date: Sat, 5 May 2012 20:06:18 -0700 [thread overview]
Message-ID: <20120506030618.GE29576@lizard> (raw)
In-Reply-To: <1336145083.2210.1.camel@rhyland-vb>
On Fri, May 04, 2012 at 08:24:43AM -0700, Rhyland Klein wrote:
> On Tue, 2012-04-24 at 23:59 -0700, Nikolaus Voss wrote:
> > Currently, the capacity exported by this driver refers to reg 0x0e,
> > which is the absolute state of charge which according to SBS
> > refers to the design capacity/ energy of the battery. It can be
> > > 100 % and drops below 100 % for a fully charged battery with
> > the battery aging.
> >
> > This is not what the user exspects of a remaining capacity
> > indication between 0 and 100 % with 100 % referring to
> > a fully charged battery. This is provided by SBS reg 0x0d,
> > which is the relative state of charge referring to the
> > full charge capacity.
> >
> > Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
> > ---
> > drivers/power/sbs-battery.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Ack-ed Rhyland Klein <rklein@nvidia.com>
Applied, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
prev parent reply other threads:[~2012-05-06 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 6:59 [PATCH] drivers/power/sbs-battery.c: capacity attr = remaining relative capacity Nikolaus Voss
2012-05-04 15:24 ` Rhyland Klein
2012-05-06 3:06 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506030618.GE29576@lizard \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann.de \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox