From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Jesper Juhl <jj@chaosbits.net>,
linux-kernel@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Subject: Re: [PATCH] ISP1704 USB Charger: Fix use-after-free error in isp1704_charger_probe()
Date: Sat, 5 May 2012 20:12:12 -0700 [thread overview]
Message-ID: <20120506031212.GF29576@lizard> (raw)
In-Reply-To: <201204222234.59624.marex@denx.de>
On Sun, Apr 22, 2012 at 10:34:59PM +0200, Marek Vasut wrote:
[...]
> > -
> > dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
> > -
> > isp1704_charger_set_power(isp, 0);
> > + kfree(isp);
Dan Carpenter sent a similar fix ~month ago, so it's in already.
> Use devm_kzalloc() and be done with all this goo?
Yeah, that's actually a good idea.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-05-06 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 20:13 [PATCH] ISP1704 USB Charger: Fix use-after-free error in isp1704_charger_probe() Jesper Juhl
2012-04-22 20:34 ` Marek Vasut
2012-05-06 3:12 ` Anton Vorontsov [this message]
2012-05-06 13:18 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506031212.GF29576@lizard \
--to=cbouatmailru@gmail.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jj@chaosbits.net \
--cc=kalle.jokiniemi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox