From: "Henrik Rydberg" <rydberg@euromail.se>
To: "benjamin.tissoires" <benjamin.tissoires@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] HID: hid-multitouch: get maxcontacts also from logical_max value
Date: Sun, 6 May 2012 21:03:23 +0200 [thread overview]
Message-ID: <20120506190322.GB12571@polaris.bitmath.org> (raw)
In-Reply-To: <1336136030-18503-3-git-send-email-benjamin.tissoires@gmail.com>
Hi,
> Win8 devices are required to present the feature "Maximum Contact Number".
> If the current value is 0, then, the driver can get the actual supported
> contact count by seeing the logical_max.
And for win7, it is zero?
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> ---
> drivers/hid/hid-multitouch.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index c6ffb05..e205d1e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -265,6 +265,8 @@ static void mt_feature_mapping(struct hid_device *hdev,
> case HID_DG_CONTACTMAX:
> td->maxcontact_report_id = field->report->id;
> td->maxcontacts = field->value[0];
> + if (!td->maxcontacts)
> + td->maxcontacts = field->logical_maximum;
> if (td->mtclass.maxcontacts)
> /* check if the maxcontacts is given by the class */
> td->maxcontacts = td->mtclass.maxcontacts;
> --
> 1.7.7.6
>
Thanks,
Henrik
next prev parent reply other threads:[~2012-05-06 18:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:53 [patch 0/5] Bug fix and win8 for hid-multitouch benjamin.tissoires
2012-05-04 12:53 ` [PATCH 1/5] HID: hid-multitouch: fix wrong protocol detection benjamin.tissoires
2012-05-06 19:01 ` Henrik Rydberg
2012-05-09 19:04 ` Benjamin Tissoires
2012-05-09 19:56 ` Henrik Rydberg
2012-05-10 8:31 ` Jiri Kosina
2012-05-10 9:32 ` Benjamin Tissoires
2012-05-10 9:37 ` Jiri Kosina
2012-05-18 21:14 ` Drews, Paul
2012-05-21 16:43 ` Benjamin Tissoires
2012-05-21 19:01 ` Drews, Paul
2012-05-04 12:53 ` [PATCH 2/5] HID: hid-multitouch: get maxcontacts also from logical_max value benjamin.tissoires
2012-05-06 19:03 ` Henrik Rydberg [this message]
2012-05-09 19:13 ` Benjamin Tissoires
2012-05-09 19:46 ` Henrik Rydberg
2012-05-10 12:15 ` Benjamin Tissoires
2012-05-10 12:46 ` Henrik Rydberg
2012-05-04 12:53 ` [PATCH 3/5] HID: hid-multitouch: support arrays for the split of the touches in a report benjamin.tissoires
2012-05-04 12:53 ` [PATCH 4/5] input: Introduce MT_CENTER_X and MT_CENTER_Y benjamin.tissoires
2012-05-04 13:48 ` Henrik Rydberg
2012-05-06 14:34 ` Benjamin Tissoires
2012-05-06 17:43 ` Henrik Rydberg
2012-05-04 12:53 ` [PATCH 5/5] HID: hid-multitouch: support T and C for win8 devices benjamin.tissoires
2012-05-09 14:39 ` [patch 0/5] Bug fix and win8 for hid-multitouch Jiri Kosina
2012-05-09 17:52 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506190322.GB12571@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox