From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755908Ab2EGI4c (ORCPT ); Mon, 7 May 2012 04:56:32 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:38833 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755896Ab2EGI4a (ORCPT ); Mon, 7 May 2012 04:56:30 -0400 Date: Mon, 7 May 2012 10:56:25 +0200 From: Ingo Molnar To: Sasha Levin Cc: torvalds@linux-foundation.org, chuck.lever@oracle.com, linux@razik.name, Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu Subject: Re: [PATCH] init: don't try mounting device as nfs root unless type fully matches Message-ID: <20120507085625.GA473@gmail.com> References: <1336230395-5215-1-git-send-email-levinsasha928@gmail.com> <20120507085419.GN16608@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120507085419.GN16608@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > * Sasha Levin wrote: > > > Currently, we'll try mounting any device who's major device number is > > UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such > > as 9p devices) but it wouldn't cause any issues since mounting the device > > as NFS would fail quickly and the code proceeded to doing the proper mount: > > > > [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy. > > [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18. > > > > Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when > > mounting NFS root, which means that now we don't immediately fail and instead > > it takes an additional 90+ seconds until we stop retrying, which has revealed > > the issue this patch fixes. > > Just wondering, which tree is commit 6829a048 included in? It > does not appear to be mainline AFAICS. appears to be: 43717c7daebf NFS: Retry mounting NFSROOT The commit ID you cited is apparently one that got exposed to linux-next but got rebased subsequently, before it went upstream, or so. Thanks, Ingo