* [PATCH] regulator: da9052: fix bug in device tree iteration loop
@ 2012-05-07 7:57 Ying-Chun Liu (PaulLiu)
2012-05-07 11:52 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Ying-Chun Liu (PaulLiu) @ 2012-05-07 7:57 UTC (permalink / raw)
To: linux-kernel; +Cc: patches, Liam Girdwood, Mark Brown, Ying-Chun Liu (PaulLiu)
From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>
The driver of da9052 is buggy due to the iteration loop of device tree.
This patch fix the loop condition to make the driver work with device tree.
Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
---
drivers/regulator/da9052-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index eaa91cc5..f8ad24a 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -444,7 +444,7 @@ static int __devinit da9052_regulator_probe(struct platform_device *pdev)
if (!nproot)
return -ENODEV;
- for (np = of_get_next_child(nproot, NULL); !np;
+ for (np = of_get_next_child(nproot, NULL); np;
np = of_get_next_child(nproot, np)) {
if (!of_node_cmp(np->name,
regulator->info->reg_desc.name)) {
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: da9052: fix bug in device tree iteration loop
2012-05-07 7:57 [PATCH] regulator: da9052: fix bug in device tree iteration loop Ying-Chun Liu (PaulLiu)
@ 2012-05-07 11:52 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-05-07 11:52 UTC (permalink / raw)
To: Ying-Chun Liu (PaulLiu); +Cc: linux-kernel, patches, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Mon, May 07, 2012 at 03:57:23PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>
>
> The driver of da9052 is buggy due to the iteration loop of device tree.
> This patch fix the loop condition to make the driver work with device tree.
Applied, thanks. I am wondering how this code was ever tested...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-07 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 7:57 [PATCH] regulator: da9052: fix bug in device tree iteration loop Ying-Chun Liu (PaulLiu)
2012-05-07 11:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox