From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Paul Mundt <lethal@linux-sh.org>
Subject: [patch 8/8] sh: Remove cpu_idle_wait()
Date: Mon, 07 May 2012 17:59:51 -0000 [thread overview]
Message-ID: <20120507175652.461648208@linutronix.de> (raw)
In-Reply-To: 20120507175450.513667947@linutronix.de
[-- Attachment #1: sh-use-kick_all_cpus_sync.patch --]
[-- Type: text/plain, Size: 2095 bytes --]
cpuidle uses the generic kick_all_cpus_sync() now. Remove the unused
code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Paul Mundt <lethal@linux-sh.org>
---
arch/sh/Kconfig | 3 ---
arch/sh/include/asm/processor.h | 1 -
arch/sh/kernel/idle.c | 20 --------------------
3 files changed, 24 deletions(-)
Index: tip/arch/sh/Kconfig
===================================================================
--- tip.orig/arch/sh/Kconfig
+++ tip/arch/sh/Kconfig
@@ -153,9 +153,6 @@ config ARCH_NO_VIRT_TO_BUS
config ARCH_HAS_DEFAULT_IDLE
def_bool y
-config ARCH_HAS_CPU_IDLE_WAIT
- def_bool y
-
config NO_IOPORT
def_bool !PCI
depends on !SH_CAYMAN && !SH_SH4202_MICRODEV && !SH_SHMIN
Index: tip/arch/sh/include/asm/processor.h
===================================================================
--- tip.orig/arch/sh/include/asm/processor.h
+++ tip/arch/sh/include/asm/processor.h
@@ -98,7 +98,6 @@ extern struct sh_cpuinfo cpu_data[];
#define cpu_relax() barrier()
void default_idle(void);
-void cpu_idle_wait(void);
void stop_this_cpu(void *);
/* Forward decl */
Index: tip/arch/sh/kernel/idle.c
===================================================================
--- tip.orig/arch/sh/kernel/idle.c
+++ tip/arch/sh/kernel/idle.c
@@ -132,10 +132,6 @@ void __init select_idle_routine(void)
pm_idle = poll_idle;
}
-static void do_nothing(void *unused)
-{
-}
-
void stop_this_cpu(void *unused)
{
local_irq_disable();
@@ -144,19 +140,3 @@ void stop_this_cpu(void *unused)
for (;;)
cpu_sleep();
}
-
-/*
- * cpu_idle_wait - Used to ensure that all the CPUs discard old value of
- * pm_idle and update to new pm_idle value. Required while changing pm_idle
- * handler on SMP systems.
- *
- * Caller must have changed pm_idle to the new value before the call. Old
- * pm_idle value will not be used by any CPU after the return of this function.
- */
-void cpu_idle_wait(void)
-{
- smp_mb();
- /* kick all the CPUs so that they exit out of pm_idle */
- smp_call_function(do_nothing, NULL, 1);
-}
-EXPORT_SYMBOL_GPL(cpu_idle_wait);
next prev parent reply other threads:[~2012-05-07 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 17:59 [patch 0/8] cpuidle: Fix and replace cpu_idle_wait copied code Thomas Gleixner
2012-05-07 17:59 ` [patch 1/8] powerpc: Fix broken cpu_idle_wait() implementation Thomas Gleixner
2012-05-08 12:25 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 2/8] smp: Implement kick_all_cpus_sync() Thomas Gleixner
2012-05-08 12:26 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 3/8] cpuidle: Use kick_all_cpus_sync() Thomas Gleixner
2012-05-08 12:26 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 4/8] x86: " Thomas Gleixner
2012-05-08 12:27 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 5/8] arm: Remove unused cpu_idle_wait() Thomas Gleixner
2012-05-08 12:28 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 7/8] ia64: " Thomas Gleixner
2012-05-08 12:29 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` [patch 6/8] powerpc: " Thomas Gleixner
2012-05-08 12:30 ` [tip:smp/hotplug] " tip-bot for Thomas Gleixner
2012-05-07 17:59 ` Thomas Gleixner [this message]
2012-05-08 12:31 ` [tip:smp/hotplug] sh: Remove cpu_idle_wait() tip-bot for Thomas Gleixner
2012-05-07 20:06 ` [patch 0/8] cpuidle: Fix and replace cpu_idle_wait copied code Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507175652.461648208@linutronix.de \
--to=tglx@linutronix.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox