From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org, jolsa@redhat.com
Subject: Re: [PATCH] perf report: fix compile failure on ppc, 32-bit
Date: Tue, 8 May 2012 10:10:33 -0300 [thread overview]
Message-ID: <20120508131033.GF2485@infradead.org> (raw)
In-Reply-To: <1336442362-53217-1-git-send-email-dsahern@gmail.com>
Em Mon, May 07, 2012 at 07:59:22PM -0600, David Ahern escreveu:
> Builds currently fail with:
> CC /tmp/pbuild/builtin-report.o
> cc1: warnings being treated as errors
> builtin-report.c: In function ‘hists__fprintf_nr_sample_events’:
> builtin-report.c:307: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘u64’
> make: *** [/tmp/pbuild/builtin-report.o] Error 1
Jiri sent this, I reproduced it yesterday on an Atom machine, will push
today, thanks,
- Arnaldo
> $ rpm -q gcc
> gcc-4.4.4-10.fc12.ppc
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> tools/perf/builtin-report.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 5df829f..7477655 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -304,7 +304,7 @@ static size_t hists__fprintf_nr_sample_events(struct hists *self,
> if (evname != NULL)
> ret += fprintf(fp, " of event '%s'", evname);
>
> - ret += fprintf(fp, "\n# Event count (approx.): %lu", nr_events);
> + ret += fprintf(fp, "\n# Event count (approx.): %" PRIu64, nr_events);
> return ret + fprintf(fp, "\n#\n");
> }
>
> --
> 1.7.5.4
prev parent reply other threads:[~2012-05-08 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 1:59 [PATCH] perf report: fix compile failure on ppc, 32-bit David Ahern
2012-05-08 13:10 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508131033.GF2485@infradead.org \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).