Re: [ 153/167] [PATCH] x86, relocs: Remove an unused variable

Jonathan Nieder
2012-05-09T06:16:38Z

Hi,

Ben Hutchings wrote:

> 3.2-stable review patch. If anyone has any objections, please let me know.
[...]
> commit 7c77cda0fe742ed07622827ce80963bbeebd1e3f upstream.
>
> sh_symtab is set but not used.
>
> [ hpa: putting this in urgent because of the sheer harmlessness of the patch:
> it quiets a build warning but does not change any generated code. ]
[...]
> --- a/arch/x86/boot/compressed/relocs.c
> +++ b/arch/x86/boot/compressed/relocs.c
> @@ -403,13 +403,11 @@ static void print_absolute_symbols(void)
> for (i = 0; i < ehdr.e_shnum; i++) {
> struct section *sec = &secs[i];
> char *sym_strtab;
> - Elf32_Sym *sh_symtab;
> int j;
>
> if (sec->shdr.sh_type != SHT_SYMTAB) {
> continue;
> }
> - sh_symtab = sec->symtab;

This patch is a no-op.

The explanation in brackets above makes perfect sense in the context
of mainline, but I don't think this belongs in stable.

Thanks,
Jonathan