Re: [ 024/167] [PATCH] md: dont call ->add_disk unless there is good reason.

Ben Hutchings
2012-05-09T12:35:09Z

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Wed, 2012-05-09 at 17:20 +1000, NeilBrown wrote:
> On Wed, 9 May 2012 01:57:17 -0500 Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> > Hi,
> >
> > Ben Hutchings wrote:
> >
> > > 3.2-stable review patch. If anyone has any objections, please let me know.
> > [...]
> > > commit ed209584c38fb74b7eecc03e5b1bfe674e591bd8 upstream.
> > >
> > > Commit 7bfec5f35c68121e7b18
> > >
> > > md/raid5: If there is a spare and a want_replacement device, start replacement.
> > >
> > > cause md_check_recovery to call ->add_disk much more often.
> > > Instead of only when the array is degraded, it is now called whenever
> > > md_check_recovery finds anything useful to do, which includes
> > > updating the metadata for clean<->dirty transition.
> > > This causes unnecessary work, and causes info messages from ->add_disk
> > > to be reported much too often.
> >
> > Does 3.2.y need this? Commit 7bfec5f35c68121e7b18 (aka v3.3-rc3~3^2~22)
> > does not seem to be part of the 3.2-stable tree.
> >
> > Jonathan
>
> Thanks for checking!
>
> Probably not needed then, but it wouldn't be harmful.

But I don't think it meets the 'stable rules' for 3.2.y, so I'll drop
it. If it turns out to be a important fix even without the earlier
change then let me know.

Ben.

--
Ben Hutchings
Life is what happens to you while you're busy making other plans.
- John Lennon

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]