From: Ingo Molnar <mingo@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Yong Zhang <yong.zhang0@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: linux-next oops in __lock_acquire for process_one_work
Date: Wed, 9 May 2012 11:25:36 +0200 [thread overview]
Message-ID: <20120509092536.GC8585@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1205081553250.4497@eggly.anvils>
* Hugh Dickins <hughd@google.com> wrote:
> On Wed, 9 May 2012, Peter Zijlstra wrote:
> > On Tue, 2012-05-08 at 11:11 -0700, Hugh Dickins wrote:
> > > Please send me the version of patch you'd like to put in
> > > (lest I make it up myself and you don't like the result).
> >
> > something like so?
>
> More like the one below: I'm not alone in preferring a comma
> between args!
Silly compilers!
> And you're not a believer in checkpatch.pl, I see: I've removed trailing
> spaces; but left the 85-col line, that's not a fight I'll have with you.
I suspect we could break up the prototype like this:
static inline void
lockdep_copy_map(struct lockdep_map *to, struct lockdep_map *from)
> I'll set it going when I get home later - thanks.
Do we still need an explanation about why it's needed and why it
makes a difference?
Thanks,
Ingo
next prev parent reply other threads:[~2012-05-09 9:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 17:19 linux-next oops in __lock_acquire for process_one_work Hugh Dickins
2012-05-07 17:57 ` Tejun Heo
2012-05-08 13:03 ` Peter Zijlstra
2012-05-08 16:58 ` Tejun Heo
2012-05-08 17:02 ` Peter Zijlstra
2012-05-08 18:11 ` Hugh Dickins
2012-05-08 22:31 ` Peter Zijlstra
2012-05-08 22:58 ` Hugh Dickins
2012-05-09 9:25 ` Ingo Molnar [this message]
2012-05-09 20:09 ` Hugh Dickins
2012-05-10 17:52 ` Hugh Dickins
2012-05-14 21:27 ` Tejun Heo
2012-05-15 11:11 ` Peter Zijlstra
2012-05-15 15:10 ` [PATCH] lockdep: fix oops in processing workqueue Tejun Heo
2012-05-15 15:29 ` Dave Jones
2012-05-15 15:31 ` Tejun Heo
2012-05-15 20:36 ` Hugh Dickins
2012-05-08 18:05 ` linux-next oops in __lock_acquire for process_one_work Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509092536.GC8585@gmail.com \
--to=mingo@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sboyd@codeaurora.org \
--cc=tj@kernel.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).