From: Ingo Molnar <mingo@kernel.org>
To: Ido Yariv <ido@wizery.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Shai Fultheim <shai@scalemp.com>
Subject: Re: [PATCH v4] vsmp: Fix number of CPUs when vsmp is disabled
Date: Wed, 9 May 2012 17:44:51 +0200 [thread overview]
Message-ID: <20120509154448.GD2653@gmail.com> (raw)
In-Reply-To: <1336552121-6742-1-git-send-email-ido@wizery.com>
* Ido Yariv <ido@wizery.com> wrote:
> +static void __init vsmp_cap_cpus(void)
> +{
> + void __iomem *address;
> + unsigned int cfg, topology, node_shift, maxcpus;
> +
> +#ifdef CONFIG_X86_VSMP
> + /* VSMP is enabled, no need to cap cpus */
> + return;
> +#elif defined(CONFIG_SMP)
> + /*
> + * CONFIG_X86_VSMP is not configured, so limit the number CPUs to the
I suspect this will throw compiler warnings in the
CONFIG_X86_VSMP && !CONFIG_SMP case.
Why not do something like:
static void __init vsmp_cap_cpus(void)
{
#if !defined(CONFIG_X86_VSMP) && defined(CONFIG_SMP)
...
#endif
}
This keeps the #ifdef complexity reasonably concentrated.
Thanks,
Ingo
next prev parent reply other threads:[~2012-05-09 15:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 12:39 [PATCH 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-06 12:39 ` [PATCH 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-04-16 7:39 ` [PATCH v2 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-16 7:39 ` [PATCH v2 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-05-07 13:19 ` Ingo Molnar
2012-05-08 0:53 ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-09 9:18 ` Ingo Molnar
2012-05-09 21:21 ` Ido Yariv
2012-06-02 22:11 ` [PATCH 1/2] x86: Introduce apic post-initialization callback Ido Yariv
2012-06-02 22:11 ` [PATCH v3 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-06-06 15:02 ` [tip:x86/platform] x86/vsmp: " tip-bot for Ravikiran Thirumalai
2012-06-08 8:52 ` Ingo Molnar
2012-06-08 15:43 ` Ido Yariv
2012-06-11 8:58 ` Ingo Molnar
2012-06-11 19:41 ` Ido Yariv
2012-06-14 10:51 ` Ingo Molnar
2012-06-14 15:43 ` [PATCH] x86/vsmp: Fix linker error when CONFIG_PROC_FS is not set Ido Yariv
2012-06-15 14:22 ` [tip:x86/platform] " tip-bot for Ido Yariv
2012-06-06 15:01 ` [tip:x86/platform] x86/platform: Introduce APIC post-initialization callback tip-bot for Ido Yariv
2012-06-14 17:34 ` H. Peter Anvin
2012-06-15 14:33 ` Ido Yariv
2012-04-28 21:33 ` [PATCH v2 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-29 3:05 ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-07 13:24 ` Ingo Molnar
2012-05-08 7:34 ` [PATCH v3] " Ido Yariv
2012-05-08 10:05 ` [tip:x86/platform] " tip-bot for Shai Fultheim
2012-05-08 12:25 ` Ingo Molnar
2012-05-09 8:03 ` Ido Yariv
2012-05-09 8:22 ` Ido Yariv
2012-05-09 8:28 ` [PATCH v4] " Ido Yariv
2012-05-09 15:44 ` Ingo Molnar [this message]
2012-05-09 15:55 ` H. Peter Anvin
2012-05-11 19:26 ` Ido Yariv
2012-05-12 1:20 ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-09 9:12 ` [tip:x86/platform] " Ingo Molnar
2012-05-09 15:27 ` Shai Fultheim (Shai@ScaleMP.com)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509154448.GD2653@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=ido@wizery.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shai@scalemp.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).