From: Tejun Heo <tj@kernel.org>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu: Fix rollback in pcpu_embed_first_chunk()
Date: Wed, 9 May 2012 10:06:03 -0700 [thread overview]
Message-ID: <20120509170603.GA24636@google.com> (raw)
In-Reply-To: <20120509143948.4ba4e949@br98xy6r>
Hello,
On Wed, May 09, 2012 at 02:39:48PM +0200, Michael Holzheu wrote:
> From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Subject: percpu: Fix rollback in pcpu_embed_first_chunk()
>
> The "out_free_areas" rollback in pcpu_embed_first_chunk calls the
> free_fn() function for all elements in area[]. This is not correct
> because not all elements have been allocated.
>
> To fix this we call free_fn() only for allocated elements.
There's already a pending fix which fixes this and another more
serious problem, which I forgot to push. I'll push it out today.
http://article.gmane.org/gmane.linux.kernel/1288808
Thanks.
--
tejun
prev parent reply other threads:[~2012-05-09 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 12:39 [PATCH] percpu: Fix rollback in pcpu_embed_first_chunk() Michael Holzheu
2012-05-09 17:06 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509170603.GA24636@google.com \
--to=tj@kernel.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox