From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755301Ab2EIRfe (ORCPT ); Wed, 9 May 2012 13:35:34 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:59930 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524Ab2EIRfd (ORCPT ); Wed, 9 May 2012 13:35:33 -0400 Date: Wed, 9 May 2012 10:35:28 -0700 From: Tejun Heo To: Sam Ravnborg Cc: Johannes Weiner , Andrew Morton , Gavin Shan , David Miller , Yinghai Lu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar Subject: Re: [patch 00/10] (no)bootmem bits for 3.5 Message-ID: <20120509173528.GD24636@google.com> References: <1336390672-14421-1-git-send-email-hannes@cmpxchg.org> <20120507204113.GD10521@merkur.ravnborg.org> <20120507220142.GA1202@cmpxchg.org> <20120508175748.GA11906@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120508175748.GA11906@merkur.ravnborg.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, May 08, 2012 at 07:57:48PM +0200, Sam Ravnborg wrote: > > It was used on x86-32 numa to try all bootmem allocations from node 0 > > first (see only remaining definition of bootmem_arch_preferred_node), > > which AFAICS nobootmem no longer respects. > > > > Shouldn't this be fixed instead? > I do not know. Tejun / Yinghai? Indeed, preferring node 0 for bootmem allocation on x86_32 got lost across the nobootmem changes. I followed the git history and preferring NODE_DATA(0) goes back to the initial git branch creation time (2.6.12) and I couldn't find any explanation, and nobody complained about the changed behavior. hpa, do you know why the code to prefer node 0 for bootmem allocations was added in the first place? Maybe we can just remove it? Thanks. -- tejun