From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Minerds <puzzleduck@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: serial: Whitespace and formatting to conform with checkpatch.sh script
Date: Wed, 9 May 2012 14:44:39 -0700 [thread overview]
Message-ID: <20120509214439.GA19041@kroah.com> (raw)
In-Reply-To: <1336569110-12835-1-git-send-email-puzzleduck@gmail.com>
On Wed, May 09, 2012 at 11:11:50PM +1000, Ben Minerds wrote:
> Removed 19 errors and 53 warnings (space before tabs, spaces required
> around '?' ':' '=', space prohibited '(', trailing whitespace, not a
> function, and parentheses are not required).
That's nice, but please don't do this all in one patch. Please do one
thing per patch (i.e. get rid of one type of warning or error per patch)
That way we can review it easier, and it can be applied easier. As it
is, this patch doesn't apply to my usb-next branch due to other patches
in there already for this file that conflict with it.
Care to redo it and break it up and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-09 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 13:11 [PATCH 1/1] USB: serial: Whitespace and formatting to conform with checkpatch.sh script Ben Minerds
2012-05-09 13:15 ` richard -rw- weinberger
2012-05-09 13:19 ` Alan Cox
2012-05-09 21:44 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-09 14:20 Ben Minerds
2012-05-09 14:38 ` richard -rw- weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509214439.GA19041@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=puzzleduck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox