From: Grant Likely <grant.likely@secretlab.ca>
To: mathieu.poirier@linaro.org
Cc: spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, arnd@arndb.de,
mathieu.poirier@linaro.org
Subject: Re: [PATCH] spi/topcliff: use correct __devexit_p annotation
Date: Wed, 09 May 2012 18:25:05 -0600 [thread overview]
Message-ID: <20120510002505.172243E08F4@localhost> (raw)
In-Reply-To: <1336602923-5724-1-git-send-email-mathieu.poirier@linaro.org>
On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier@linaro.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> __devexit functions are discarded when CONFIG_HOTPLUG
> is not set, so the symbol needs to be referenced carefully.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-topcliff-pch.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index ec47d3b..77c4562 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
> .name = "pch_spi",
> .id_table = pch_spi_pcidev_id,
> .probe = pch_spi_probe,
> - .remove = pch_spi_remove,
> + .remove = __devexit_p(pch_spi_remove),
> .suspend = pch_spi_suspend,
> .resume = pch_spi_resume,
> };
> --
> 1.7.5.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
prev parent reply other threads:[~2012-05-10 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:35 [PATCH] spi/topcliff: use correct __devexit_p annotation mathieu.poirier
2012-05-10 0:25 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510002505.172243E08F4@localhost \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox