* [PATCH] spi/topcliff: use correct __devexit_p annotation
@ 2012-05-09 22:35 mathieu.poirier
2012-05-10 0:25 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: mathieu.poirier @ 2012-05-09 22:35 UTC (permalink / raw)
To: grant.likely; +Cc: spi-devel-general, linux-kernel, arnd, mathieu.poirier
From: Arnd Bergmann <arnd@arndb.de>
__devexit functions are discarded when CONFIG_HOTPLUG
is not set, so the symbol needs to be referenced carefully.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/spi/spi-topcliff-pch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index ec47d3b..77c4562 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
.name = "pch_spi",
.id_table = pch_spi_pcidev_id,
.probe = pch_spi_probe,
- .remove = pch_spi_remove,
+ .remove = __devexit_p(pch_spi_remove),
.suspend = pch_spi_suspend,
.resume = pch_spi_resume,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/topcliff: use correct __devexit_p annotation
2012-05-09 22:35 [PATCH] spi/topcliff: use correct __devexit_p annotation mathieu.poirier
@ 2012-05-10 0:25 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-05-10 0:25 UTC (permalink / raw)
To: mathieu.poirier; +Cc: spi-devel-general, linux-kernel, arnd, mathieu.poirier
On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier@linaro.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> __devexit functions are discarded when CONFIG_HOTPLUG
> is not set, so the symbol needs to be referenced carefully.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/spi-topcliff-pch.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index ec47d3b..77c4562 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
> .name = "pch_spi",
> .id_table = pch_spi_pcidev_id,
> .probe = pch_spi_probe,
> - .remove = pch_spi_remove,
> + .remove = __devexit_p(pch_spi_remove),
> .suspend = pch_spi_suspend,
> .resume = pch_spi_resume,
> };
> --
> 1.7.5.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-10 0:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-09 22:35 [PATCH] spi/topcliff: use correct __devexit_p annotation mathieu.poirier
2012-05-10 0:25 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox