Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100

Greg KH
2012-05-02T20:21:38Z

On Wed, May 02, 2012 at 10:12:43PM +0200, Markus Franke wrote:
> Dear Greg,
>
> Am 30.04.2012 04:13, schrieb Greg KH:
> >On Thu, Apr 12, 2012 at 12:40:30AM +0200, Markus Franke wrote:
> >>This patch adds a 1-wire slave device driver for the DS28E04-100.
> >>
> >>Signed-off-by: Markus Franke<franm@hrz.tu-chemnitz.de>
> >>Acked-by: Evgeniy Polyakov<zbr@ioremap.net>
> >
> >You have a lot of checkpatch warnings and errors, and you are creating
>
> Don't have a clue what you mean. You were able to apply the patch
> successfully in the past.

Applying it was fine, but the patch created lots of problems if you ran
it through the scripts/checkpatch.pl tool. Please fix all of those
warnings and errors up.

> >new sysfs files with no documentation at all as to what you are doing,
> >and why you are doing it. sysfs binary files at that, which should not
> >be used by ANY code that is trying to intrepret the data being sent to
> >those files, sysfs binary files are for "pass-through" mode only.
>
> Well, I just stuck to the way things are done in already existing
> drivers e.g. drivers/w1/slaves/w1_ds2433.c

Really? Ick, where are those files documented?

greg k-h