Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100

Greg KH
2012-04-30T05:09:15Z

On Thu, Apr 12, 2012 at 12:40:30AM +0200, Markus Franke wrote:
> This patch adds a 1-wire slave device driver for the DS28E04-100.
>
> Signed-off-by: Markus Franke <franm@hrz.tu-chemnitz.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Andrew asked me to relook at this patch, and it turns out to be pretty
messy, I should have never applid it.

You have a lot of checkpatch warnings and errors, and you are creating
new sysfs files with no documentation at all as to what you are doing,
and why you are doing it. sysfs binary files at that, which should not
be used by ANY code that is trying to intrepret the data being sent to
those files, sysfs binary files are for "pass-through" mode only.

So please redo this patch, cleaning up all of the warnings and errors,
and use the standard kernel interfaces for this type of stuff (i.e. not
sysfs binary files.)

I've reverted it from my tree now, sorry.

greg k-h