From: Grant Likely <grant.likely@secretlab.ca>
To: Laxman Dewangan <ldewangan@nvidia.com>,
linus.walleij@stericsson.com, sameo@linux.intel.com,
broonie@opensource.wolfsonmicro.com, jedu@slimlogic.co.uk,
lrg@slimlogic.co.uk
Cc: linux-kernel@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 4/4] gpio: tps65910: move this as platform driver
Date: Fri, 11 May 2012 11:40:11 -0600 [thread overview]
Message-ID: <20120511174011.3160B3E0791@localhost> (raw)
In-Reply-To: <1336569057-3890-5-git-send-email-ldewangan@nvidia.com>
On Wed, 9 May 2012 18:40:57 +0530, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Make the gpio-tps65910 as platform driver and register
> this from tps65910 core driver as mfd sub device.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Minor comment below, but otherwise:
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> +static struct platform_driver tps65910_gpio_driver = {
> + .driver.name = "tps65910-gpio",
> + .driver.owner = THIS_MODULE,
> + .probe = tps65910_gpio_probe,
> + .remove = __devexit_p(tps65910_gpio_remove),
> +};
> +
> +static int __init tps65910_gpio_init(void)
> +{
> + return platform_driver_register(&tps65910_gpio_driver);
> +}
> +subsys_initcall(tps65910_gpio_init);
> +
> +static void __exit tps65910_gpio_exit(void)
> +{
> + platform_driver_unregister(&tps65910_gpio_driver);
> +}
> +module_exit(tps65910_gpio_exit);
module_platform_driver()
next prev parent reply other threads:[~2012-05-11 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 13:10 [PATCH 0/4] mfd:tps65910: use devm_* and register gpio as platform driver Laxman Dewangan
2012-05-09 13:10 ` [PATCH 1/4] mfd: tps65910: cache register when we need it Laxman Dewangan
2012-05-09 14:55 ` Mark Brown
2012-05-09 13:10 ` [PATCH 2/4] mfd: tps65910: convert all allocation to devm_* Laxman Dewangan
2012-05-09 15:11 ` Mark Brown
2012-05-09 13:10 ` [PATCH 3/4] mfd: tps65910: register gpio as mfd device Laxman Dewangan
2012-05-09 13:10 ` [PATCH 4/4] gpio: tps65910: move this as platform driver Laxman Dewangan
2012-05-11 17:40 ` Grant Likely [this message]
2012-05-11 19:08 ` Mark Brown
2012-05-11 13:14 ` [PATCH 0/4] mfd:tps65910: use devm_* and register gpio " Samuel Ortiz
2012-05-11 13:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511174011.3160B3E0791@localhost \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox