From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759990Ab2EKTBC (ORCPT ); Fri, 11 May 2012 15:01:02 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:65495 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756214Ab2EKTA6 (ORCPT ); Fri, 11 May 2012 15:00:58 -0400 From: Grant Likely Subject: Re: [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5 To: Kukjin Kim , Olof Johansson Cc: kgene.kim@samsung.com, linus.walleij@stericsson.com, sangsu4u.park@samsung.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <4F846C53.1070407@samsung.com> References: <1333913007-16032-1-git-send-email-olof@lixom.net> <4F846C53.1070407@samsung.com> Date: Fri, 11 May 2012 13:00:55 -0600 Message-Id: <20120511190055.4ED363E0791@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Apr 2012 10:22:27 -0700, Kukjin Kim wrote: > Olof Johansson wrote: > > Only code move, no functional change. > > > > Main reason to do this was to get rid of the warnings: > > > > drivers/gpio/gpio-samsung.c: In function 'samsung_gpiolib_init': > > drivers/gpio/gpio-samsung.c:2974:1: warning: label 'err_ioremap4' defined but not used [-Wunused-label] > > drivers/gpio/gpio-samsung.c:2722:47: warning: unused variable 'gpio_base4' [-Wunused-variable] > > > > without adding more ifdef mess. > > > > I think this whole file would do well being coverted over to a platform > > driver and moving most of the tables out to SoC code and/or device trees, > > but since that changes init ordering it needs to be done with some care, > > i.e. not at this time. > > > > Signed-off-by: Olof Johansson > > Looks ok to me :) > > Acked-by: Kukjin Kim Applied, thanks. g.