* [PATCH] i2c: davinci: Free requested IRQ in remove
@ 2012-05-03 13:56 Marcus Folkesson
2012-05-12 12:36 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2012-05-03 13:56 UTC (permalink / raw)
To: Jean Delvare, Ben Dooks, Marcus Folkesson; +Cc: linux-i2c, linux-kernel
The freed IRQ is not necessary the one requested in probe.
Even if it was, with two or more i2c-controllers it will fails anyway.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/i2c/busses/i2c-davinci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index a76d85f..79b4bcb 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -755,7 +755,7 @@ static int davinci_i2c_remove(struct platform_device *pdev)
dev->clk = NULL;
davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, 0);
- free_irq(IRQ_I2C, dev);
+ free_irq(dev->irq, dev);
iounmap(dev->base);
kfree(dev);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: davinci: Free requested IRQ in remove
2012-05-03 13:56 [PATCH] i2c: davinci: Free requested IRQ in remove Marcus Folkesson
@ 2012-05-12 12:36 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2012-05-12 12:36 UTC (permalink / raw)
To: Marcus Folkesson; +Cc: Jean Delvare, Ben Dooks, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Thu, May 03, 2012 at 03:56:36PM +0200, Marcus Folkesson wrote:
> The freed IRQ is not necessary the one requested in probe.
> Even if it was, with two or more i2c-controllers it will fails anyway.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Applied to current, thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-12 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-03 13:56 [PATCH] i2c: davinci: Free requested IRQ in remove Marcus Folkesson
2012-05-12 12:36 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).