From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: x86@kernel.org, kvm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 7/7] kvm: host side for eoi optimization
Date: Sun, 13 May 2012 13:04:26 +0300 [thread overview]
Message-ID: <20120513100426.GG4296@redhat.com> (raw)
In-Reply-To: <20120513100127.GB23273@redhat.com>
On Sun, May 13, 2012 at 01:01:28PM +0300, Michael S. Tsirkin wrote:
> > > + if (eoi_enabled(vcpu))
> > > + eoi_clr_pending(vcpu);
> > > + vcpu->arch.eoi.msr_val = data;
> > > + kvm_gfn_to_hva_cache_init(vcpu->kvm, &vcpu->arch.eoi.data, addr);
> > This may fail.
>
> On invalid address, yes. Then the cache hva will be set to invalid
> so accesses will fail too. So a malicious guest is only hurting
> itself.
> Maybe add a comment here?
>
Kill it with #GP like other MSRs do.
--
Gleb.
next prev parent reply other threads:[~2012-05-13 10:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1336679924.git.mst@redhat.com>
2012-05-11 7:38 ` [PATCHv2 1/7] apic: fix typo EIO_ACK -> EOI_ACK and document Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 2/7] apic: use symbolic APIC_EOI_ACK Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 3/7] x86: add apic->eoi_write callback Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 4/7] x86: eoi micro-optimization Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 5/7] kvm_para: guest side for eoi avoidance Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 6/7] x86/bitops: note on __test_and_clear_bit atomicity Michael S. Tsirkin
2012-05-11 7:38 ` [PATCHv2 7/7] kvm: host side for eoi optimization Michael S. Tsirkin
2012-05-13 9:33 ` Gleb Natapov
2012-05-13 10:01 ` Michael S. Tsirkin
2012-05-13 10:04 ` Gleb Natapov [this message]
2012-05-13 15:15 ` Michael S. Tsirkin
2012-05-11 7:43 ` [PATCH] qemu: whitelist kvm pv eoi feature Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120513100426.GG4296@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).