From: Andi Shyti <andi.shyti@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
Grazvydas Ignotas <notasas@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 3/4] power_supply/MFD: twl4030_charger: Allow charger to control the regulator that feeds it.
Date: Sun, 13 May 2012 20:12:08 +0200 [thread overview]
Message-ID: <20120513181208.GA2641@andi> (raw)
In-Reply-To: <20120508214040.2844.5662.stgit@notabene.brown>
Hi Neil,
On Wed, May 09, 2012 at 07:40:40AM +1000, NeilBrown wrote:
> @@ -183,6 +186,12 @@ static int twl4030_charger_enable_usb(struct twl4030_bci *bci, bool enable)
> return -EACCES;
> }
>
> + /* Need to keep regulator on */
> + if (!bci->usb_enabled) {
> + regulator_enable(bci->usb_reg);
Should you consider here a failure case?
> + bci->usb_enabled = 1;
> + }
> +
> /* forcing the field BCIAUTOUSB (BOOT_BCI[1]) to 1 */
> ret = twl4030_clear_set_boot_bci(0, TWL4030_BCIAUTOUSB);
> if (ret < 0)
> @@ -511,6 +524,8 @@ static int __init twl4030_bci_probe(struct platform_device *pdev)
> bci->usb.num_properties = ARRAY_SIZE(twl4030_charger_props);
> bci->usb.get_property = twl4030_bci_get_property;
>
> + bci->usb_reg = regulator_get(bci->dev, "bci3v1");
... and here.
Andi
next prev parent reply other threads:[~2012-05-13 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 21:40 [PATCH 0/4] twl4030_charger improvements NeilBrown
2012-05-08 21:40 ` [PATCH 1/4] power_supply: twl4030_charger: Fix some typos NeilBrown
2012-05-08 21:40 ` [PATCH 2/4] power_supply: twl4030_charger: add backup-battery charging NeilBrown
2012-05-08 21:40 ` [PATCH 4/4] usb: otg: twl4030-usb: Don't power down phy when it is in-use by charger NeilBrown
2012-05-13 18:14 ` Andi Shyti
2012-05-18 2:50 ` NeilBrown
2012-05-21 22:10 ` Andi Shyti
2012-05-08 21:40 ` [PATCH 3/4] power_supply/MFD: twl4030_charger: Allow charger to control the regulator that feeds it NeilBrown
2012-05-11 9:42 ` Samuel Ortiz
2012-05-13 18:12 ` Andi Shyti [this message]
2012-05-18 2:46 ` NeilBrown
2012-05-21 22:08 ` Andi Shyti
2012-05-11 9:45 ` [PATCH 0/4] twl4030_charger improvements Samuel Ortiz
2012-06-20 3:33 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120513181208.GA2641@andi \
--to=andi.shyti@gmail.com \
--cc=balbi@ti.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neilb@suse.de \
--cc=notasas@gmail.com \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).