From: Andi Shyti <andi.shyti@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
Grazvydas Ignotas <notasas@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 4/4] usb: otg: twl4030-usb: Don't power down phy when it is in-use by charger.
Date: Sun, 13 May 2012 20:14:09 +0200 [thread overview]
Message-ID: <20120513181409.GB2641@andi> (raw)
In-Reply-To: <20120508214040.2844.81364.stgit@notabene.brown>
Hi,
On Wed, May 09, 2012 at 07:40:40AM +1000, NeilBrown wrote:
> @@ -388,10 +388,16 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on)
> (PHY_CLK_CTRL_CLOCKGATING_EN |
> PHY_CLK_CTRL_CLK32K_EN));
> } else {
> - __twl4030_phy_power(twl, 0);
> regulator_disable(twl->usb1v5);
> regulator_disable(twl->usb1v8);
> regulator_disable(twl->usb3v1);
> + if (!regulator_is_enabled(twl->usb3v1))
> + /* no-one else is requesting this
> + * so it is OK to power-down the
> + * phy. Sometimes a charger might
> + * hold the regulator active.
> + */
> + __twl4030_phy_power(twl, 0);
> }
Usually a regulator line is shared by more than one device and
regulator_is_enable() returns true if at least one of these
devices is holding the regulator. This means that here the check
will not work if this is your case.
Andi
next prev parent reply other threads:[~2012-05-13 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 21:40 [PATCH 0/4] twl4030_charger improvements NeilBrown
2012-05-08 21:40 ` [PATCH 1/4] power_supply: twl4030_charger: Fix some typos NeilBrown
2012-05-08 21:40 ` [PATCH 3/4] power_supply/MFD: twl4030_charger: Allow charger to control the regulator that feeds it NeilBrown
2012-05-11 9:42 ` Samuel Ortiz
2012-05-13 18:12 ` Andi Shyti
2012-05-18 2:46 ` NeilBrown
2012-05-21 22:08 ` Andi Shyti
2012-05-08 21:40 ` [PATCH 4/4] usb: otg: twl4030-usb: Don't power down phy when it is in-use by charger NeilBrown
2012-05-13 18:14 ` Andi Shyti [this message]
2012-05-18 2:50 ` NeilBrown
2012-05-21 22:10 ` Andi Shyti
2012-05-08 21:40 ` [PATCH 2/4] power_supply: twl4030_charger: add backup-battery charging NeilBrown
2012-05-11 9:45 ` [PATCH 0/4] twl4030_charger improvements Samuel Ortiz
2012-06-20 3:33 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120513181409.GB2641@andi \
--to=andi.shyti@gmail.com \
--cc=balbi@ti.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neilb@suse.de \
--cc=notasas@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox