From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
arnaldo.melo@gmail.com,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 0/8] Annotation weekly ponies delivery
Date: Mon, 14 May 2012 13:55:51 +0200 [thread overview]
Message-ID: <20120514115551.GA6479@gmail.com> (raw)
In-Reply-To: <1336994000.2443.24.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Sat, 2012-05-12 at 13:40 -0700, Linus Torvalds wrote:
> > The whole "-e cycles:pp" doesn't work any more. I don't get any nice
> > PEBS information, I get the totally useless irq-based profiling.
> >
> > The difference for a "make -j" profile is quite stunning:
> >
> > Doing "perf record -f -e cycles:pp -F 20000 make -j"
> >
> > - my current git:
> >
> > [ perf record: Woken up 47 times to write data ]
> > [ perf record: Captured and wrote 11.890 MB perf.data (~519462 samples) ]
> >
> > - with the above tree pulled into my current git tree (but compiling
> > the same old tree):
> >
> > [ perf record: Woken up 1 times to write data ]
> > [ perf record: Captured and wrote 0.031 MB perf.data (~1375 samples) ]
>
> The output simply suggests we're not getting enough samples
> not that PEBS isn't working, in fact I can could reproduce
> without using PEBS.
>
> This bisected to the below commit, the code has since been
> changed again and all that evlist stuff gives me a head-ache.
> Acme, Namhyung ?
>
> 55261f46702cec96911a81aacfb3cba13434d304 is the first bad commit
> commit 55261f46702cec96911a81aacfb3cba13434d304
> Author: Namhyung Kim <namhyung.kim@lge.com>
> Date: Mon May 7 14:08:59 2012 +0900
>
> perf evlist: Fix creation of cpu map
Another detail seems to be that the bug takes per-task-inherited
profiling. Doing:
perf record -a -e cycles:pp make -j64 bzImage
produces the expected number of events. Without the '-a' the bug
Linus found triggers.
Similarly, 'perf top' does not trigger the bug - because it's
using per CPU, not per task (inherited) profiling.
Thanks,
Ingo
next prev parent reply other threads:[~2012-05-14 11:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 19:52 [GIT PULL 0/8] Annotation weekly ponies delivery Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 1/8] perf annotate: Use raw form for register indirect call instructions Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 2/8] perf annotate: Resolve symbols using objdump comment Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 3/8] perf annotate: Resolve symbols using objdump comment for single op ins Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 4/8] perf annotate: Augment lock instruction output Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 5/8] perf annotate: Introduce ->free() method in ins_ops Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 6/8] perf annotate browser: Count the numbers of jump sources to a target Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 7/8] perf annotate browser: Show 'jumpy' functions Arnaldo Carvalho de Melo
2012-05-12 19:53 ` [PATCH 8/8] perf annotate browser: Add key bindings help window Arnaldo Carvalho de Melo
2012-05-12 20:40 ` [GIT PULL 0/8] Annotation weekly ponies delivery Linus Torvalds
2012-05-12 21:25 ` Arnaldo Carvalho de Melo
2012-05-12 22:29 ` Linus Torvalds
2012-05-14 7:05 ` Ingo Molnar
2012-05-14 11:13 ` Peter Zijlstra
2012-05-14 11:55 ` Ingo Molnar [this message]
2012-05-14 15:06 ` Namhyung Kim
2012-05-15 4:48 ` Namhyung Kim
2012-05-15 10:32 ` Peter Zijlstra
2012-05-15 14:44 ` Namhyung Kim
2012-05-15 17:07 ` Peter Zijlstra
2012-05-16 5:57 ` Namhyung Kim
2012-05-16 8:19 ` Namhyung Kim
2012-05-17 0:13 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514115551.GA6479@gmail.com \
--to=mingo@kernel.org \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=arjan@infradead.org \
--cc=arnaldo.melo@gmail.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).