* [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs [not found] <1337021163-1487-1-git-send-email-changbinx.du@intel.com> @ 2012-05-14 6:51 ` Du, ChangbinX 2012-05-14 9:59 ` Sergei Shtylyov 0 siblings, 1 reply; 6+ messages in thread From: Du, ChangbinX @ 2012-05-14 6:51 UTC (permalink / raw) To: gregkh@linuxfoundation.org Cc: mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org As real device-nodes managed by udev whose nodes lived in /dev/bus/usb are mostly used today, let testusb tool use that directory as one default path make tool be more convenient to use. Signed-off-by: Du Changbin <changbinx.du@intel.com> --- tools/usb/testusb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index 6e0f567..c6c839e 100644 --- a/tools/usb/testusb.c +++ b/tools/usb/testusb.c @@ -358,6 +358,7 @@ static const char *usbfs_dir_find(void) { static char usbfs_path_0[] = "/dev/usb/devices"; static char usbfs_path_1[] = "/proc/bus/usb/devices"; + static char udev_usb_path[] = "/dev/bus/usb"; static char *const usbfs_paths[] = { usbfs_path_0, usbfs_path_1 @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void) } } while (++it != end); + /* real device-nodes managed by udev */ + if (access(udev_usb_path, F_OK) == 0) { + return udev_usb_path; + } + return NULL; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-14 6:51 ` [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs Du, ChangbinX @ 2012-05-14 9:59 ` Sergei Shtylyov 2012-05-14 10:49 ` Du, ChangbinX 0 siblings, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2012-05-14 9:59 UTC (permalink / raw) To: Du, ChangbinX Cc: gregkh@linuxfoundation.org, mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Hello. On 14-05-2012 10:51, Du, ChangbinX wrote: > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb > are mostly used today, let testusb tool use that directory as one default > path make tool be more convenient to use. > Signed-off-by: Du Changbin<changbinx.du@intel.com> > --- > tools/usb/testusb.c | 6 ++++++ > 1 file changed, 6 insertions(+) > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c > index 6e0f567..c6c839e 100644 > --- a/tools/usb/testusb.c > +++ b/tools/usb/testusb.c [...] > @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void) > } > } while (++it != end); > > + /* real device-nodes managed by udev */ > + if (access(udev_usb_path, F_OK) == 0) { > + return udev_usb_path; > + } Why {} with single statement? WBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-14 9:59 ` Sergei Shtylyov @ 2012-05-14 10:49 ` Du, ChangbinX 2012-05-14 11:27 ` Sergei Shtylyov 2012-05-14 15:39 ` gregkh 0 siblings, 2 replies; 6+ messages in thread From: Du, ChangbinX @ 2012-05-14 10:49 UTC (permalink / raw) To: Sergei Shtylyov Cc: gregkh@linuxfoundation.org, mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Hello. On 14-05-2012 10:51, Du, ChangbinX wrote: > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb > are mostly used today, let testusb tool use that directory as one > default path make tool be more convenient to use. > Signed-off-by: Du Changbin<changbinx.du@intel.com> > --- > tools/usb/testusb.c | 6 ++++++ > 1 file changed, 6 insertions(+) > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index > 6e0f567..c6c839e 100644 > --- a/tools/usb/testusb.c > +++ b/tools/usb/testusb.c [...] > @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void) > } > } while (++it != end); > > + /* real device-nodes managed by udev */ > + if (access(udev_usb_path, F_OK) == 0) { > + return udev_usb_path; > + } Why {} with single statement? Hi, thanks for your tip. It's a code style issue. I will remove {}. By the way, I don't know how I can do with this case? Resend a new patch? Do I need include discussion message in new patch mail? And how can I know my patch has be accepted? I am a newbie, could you help me? Changbin WBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-14 10:49 ` Du, ChangbinX @ 2012-05-14 11:27 ` Sergei Shtylyov 2012-05-15 1:52 ` Du, ChangbinX 2012-05-14 15:39 ` gregkh 1 sibling, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2012-05-14 11:27 UTC (permalink / raw) To: Du, ChangbinX Cc: gregkh@linuxfoundation.org, mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org On 14-05-2012 14:49, Du, ChangbinX wrote: >> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb >> are mostly used today, let testusb tool use that directory as one >> default path make tool be more convenient to use. >> Signed-off-by: Du Changbin<changbinx.du@intel.com> >> --- >> tools/usb/testusb.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index >> 6e0f567..c6c839e 100644 >> --- a/tools/usb/testusb.c >> +++ b/tools/usb/testusb.c > [...] >> @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void) >> } >> } while (++it != end); >> >> + /* real device-nodes managed by udev */ >> + if (access(udev_usb_path, F_OK) == 0) { >> + return udev_usb_path; >> + } > Why {} with single statement? > Hi, thanks for your tip. It's a code style issue. I will remove {}. > By the way, I don't know how I can do with this case? Resend a new patch? Yes, marking that thsi is a new version of patch in the [PATCH] prefix, like [PATCH v2]. > Do I need include discussion message in new patch mail? Not necessarily, just indicate the change compared to the old version under the --- tear line. > And how can I know my patch has be accepted? I am a newbie, could you help me? You will get a reply from the maintainer, Greg Kroah-Hartman, I think. > Changbin WBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-14 11:27 ` Sergei Shtylyov @ 2012-05-15 1:52 ` Du, ChangbinX 0 siblings, 0 replies; 6+ messages in thread From: Du, ChangbinX @ 2012-05-15 1:52 UTC (permalink / raw) To: Sergei Shtylyov Cc: gregkh@linuxfoundation.org, mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org > By the way, I don't know how I can do with this case? Resend a new patch? Yes, marking that thsi is a new version of patch in the [PATCH] prefix, like [PATCH v2]. > Do I need include discussion message in new patch mail? Not necessarily, just indicate the change compared to the old version under the --- tear line. > And how can I know my patch has be accepted? I am a newbie, could you help me? You will get a reply from the maintainer, Greg Kroah-Hartman, I think. > Changbin WBR, Sergei That's very nice of you, thanks a lot! Du Changbin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs 2012-05-14 10:49 ` Du, ChangbinX 2012-05-14 11:27 ` Sergei Shtylyov @ 2012-05-14 15:39 ` gregkh 1 sibling, 0 replies; 6+ messages in thread From: gregkh @ 2012-05-14 15:39 UTC (permalink / raw) To: Du, ChangbinX Cc: Sergei Shtylyov, mina86@mina86.com, Fleming, Matt, balbi@ti.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org On Mon, May 14, 2012 at 10:49:06AM +0000, Du, ChangbinX wrote: > > Hello. > > On 14-05-2012 10:51, Du, ChangbinX wrote: > > > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb > > are mostly used today, let testusb tool use that directory as one > > default path make tool be more convenient to use. > > > Signed-off-by: Du Changbin<changbinx.du@intel.com> > > --- > > tools/usb/testusb.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index > > 6e0f567..c6c839e 100644 > > --- a/tools/usb/testusb.c > > +++ b/tools/usb/testusb.c > [...] > > @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void) > > } > > } while (++it != end); > > > > + /* real device-nodes managed by udev */ > > + if (access(udev_usb_path, F_OK) == 0) { > > + return udev_usb_path; > > + } > > Why {} with single statement? > > Hi, thanks for your tip. It's a code style issue. I will remove {}. > > By the way, I don't know how I can do with this case? Resend a new > patch? Do I need include discussion message in new patch mail? Please resend a new patch with this fixed up. > And how can I know my patch has be accepted? I am a newbie, could you > help me? You will get an automated email from my patch system when it is applied. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-15 1:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1337021163-1487-1-git-send-email-changbinx.du@intel.com>
2012-05-14 6:51 ` [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs Du, ChangbinX
2012-05-14 9:59 ` Sergei Shtylyov
2012-05-14 10:49 ` Du, ChangbinX
2012-05-14 11:27 ` Sergei Shtylyov
2012-05-15 1:52 ` Du, ChangbinX
2012-05-14 15:39 ` gregkh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox