From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353Ab2ENVTT (ORCPT ); Mon, 14 May 2012 17:19:19 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:38041 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757683Ab2ENVTS (ORCPT ); Mon, 14 May 2012 17:19:18 -0400 Date: Mon, 14 May 2012 14:19:13 -0700 From: Tejun Heo To: Jiri Kosina Cc: Andrew Morton , Jens Axboe , NeilBrown , linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH] floppy: remove floppy-specific O_EXCL handling Message-ID: <20120514211913.GL2366@google.com> References: <20120514162521.GA2366@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, May 14, 2012 at 10:42:58PM +0200, Jiri Kosina wrote: > Because since > > commit e525fd89d380c4a94c0d63913a1dd1a593ed25e7 > Author: Tejun Heo > Date: Sat Nov 13 11:55:17 2010 +0100 > > block: make blkdev_get/put() handle exclusive access > > mount of /dev/fd0 actually causes the fd0 block device be claimed with > _EXCL. Before this commit, you are able to mount /dev/fd0 and then open() > it afterward. After this commit you can't any more, because mounting > /dev/fd0 already passes O_EXCL to floppy_open(), and thus noone else can > open(/dev/fd0) any more. > > My commit brings things back into shape, i.e. you can, equally to other > block devices, both mount it and open() it afterwards. Ah, that makes sense. Maybe it's a good idea to note why the change is necessary in the commit message too? Acked-by: Tejun Heo Thanks. -- tejun