Re: [PATCH] floppy: remove floppy-specific O_EXCL handling

Tejun Heo
2012-05-14T21:19:19Z

Hello,

On Mon, May 14, 2012 at 10:42:58PM +0200, Jiri Kosina wrote:
> Because since
>
> commit e525fd89d380c4a94c0d63913a1dd1a593ed25e7
> Author: Tejun Heo <tj@kernel.org>
> Date: Sat Nov 13 11:55:17 2010 +0100
>
> block: make blkdev_get/put() handle exclusive access
>
> mount of /dev/fd0 actually causes the fd0 block device be claimed with
> _EXCL. Before this commit, you are able to mount /dev/fd0 and then open()
> it afterward. After this commit you can't any more, because mounting
> /dev/fd0 already passes O_EXCL to floppy_open(), and thus noone else can
> open(/dev/fd0) any more.
>
> My commit brings things back into shape, i.e. you can, equally to other
> block devices, both mount it and open() it afterwards.

Ah, that makes sense. Maybe it's a good idea to note why the change
is necessary in the commit message too?

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun