Re: [PATCH] floppy: remove floppy-specific O_EXCL handling

Joe Perches
2012-05-14T16:49:51Z

On Mon, 2012-05-14 at 09:25 -0700, Tejun Heo wrote:
> Hello,
>
> On Sun, May 13, 2012 at 11:02:07AM +0200, Jiri Kosina wrote:
> > Block layer now handles O_EXCL in a generic way for block devices.
> >
> > The semantics is however different for floppy and all other block devices,
> > as floppy driver contains its own O_EXCL handling.
> >
> > The semantics for all-but-floppy bdevs is "there can be at most one O_EXCL
> > open of this file", while for floppy bdev the semantics is "if someone has
> > the bdev open with O_EXCL, noone else can open it".
> >
> > Remove the floppy-specific handling and let the generic bdev code O_EXCL
> > handling take over.
> >
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> Patch looks good to me but why do we want to change this at this
> point?

Because the hobgoblins of consistency are as fun to hunt as the wumpus?