From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, matt.fleming@linux.intel.com,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86-64: use EFI to deal with platform wall clock
Date: Tue, 15 May 2012 14:20:06 +0100 [thread overview]
Message-ID: <20120515132006.GA26196@srcf.ucam.org> (raw)
In-Reply-To: <4FB273EB0200007800083D32@nat28.tlf.novell.com>
On Tue, May 15, 2012 at 02:19:07PM +0100, Jan Beulich wrote:
> I would have expected that things work that way, but they
> don't. In particular is the function in efi_64.c that's being
> modified here called from efi_call_phys_{pro,epi}log(), and at
> that point we can't expect virtual addresses to be uniformly
> set yet. So it's a physical call that requires the fixup done
> here, as efi_set_executable() simply expects ->virt_addr to
> be valid. I suspect that no physical calls other than
> phys_efi_set_virtual_address_map() were being done so far
> at all on 64-bit, hiding the problem.
In that case we need to split the mapping code into two chunks and
configure the memory map earlier. You can't depend on __va() doing
anything useful on runtime addresses.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-05-15 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 12:18 [PATCH] x86-64: use EFI to deal with platform wall clock Jan Beulich
2012-05-15 12:47 ` Matthew Garrett
2012-05-15 13:19 ` Jan Beulich
2012-05-15 13:20 ` Matthew Garrett [this message]
2012-05-16 12:18 ` Jan Beulich
2012-05-16 12:39 ` Matthew Garrett
2012-05-16 12:59 ` Jan Beulich
2012-05-16 13:07 ` Matthew Garrett
2012-05-17 8:31 ` Matt Fleming
2012-05-25 15:00 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2012-05-25 15:20 Jan Beulich
2012-05-25 15:24 ` Matthew Garrett
2012-05-25 15:30 ` Jan Beulich
2012-05-25 15:34 ` Matthew Garrett
2012-06-06 9:47 ` Ingo Molnar
2012-05-26 10:26 ` Matt Fleming
2012-06-04 8:11 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515132006.GA26196@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@linux.intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox