Re: [lm-sensors] [PATCH] hwmon: Generic ADC support for hwmon

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Tue, May 15, 2012 at 08:42:57AM -0400, R, Durgadoss wrote:
> Hi Guenter,
> 
> Thanks for a quick reply.
> 
> > On Tue, May 15, 2012 at 10:26:48AM -0400, Jenny TC wrote:
> > > Currently drivers are using custom APIs to communicate with ADC driver.
> > > So it make sense to have generic APIs to commnicate with ADC drivers.
> > > This patch introduces generic APIs to communicate with ADC drivers.
> > >
> > > Signed-off-by: Jenny TC <jenny.tc@intel.com>
> > 
> > Hi Jenny,
> > 
> > Do you have a practical use case ?
> 
> We have some platform specific component drivers, thermal drivers,
> battery drivers using this General purpose ADC in the platform.
> That's why we thought of doing something like this.
> 
> > 
> > Also, shouldn't those generic ADCs rather be supported through the IO
> > subsystem ?
> > After all, hwmon is all about hardware monitoring, not to provide generic ADC
> > access.
> 
> In this case, can we try this in iio or mfd subsystem ?
> Kindly advise.
> 
I meant iio (more specifically staging/iio/adc).

I suspect it might make more sense to have a hwmon client, in parallel to the other
users/clients (battery control, thermal etc), if the values reported by the ADC reflect
information relevant for hardware monitoring.

Thanks,
Guenter