public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: mdharm-usb@one-eyed-alien.net, linux-kernel@vger.kernel.org
Subject: Re: styling fixes in drivers/usb/storage/usb.c
Date: Tue, 15 May 2012 08:10:50 -0700	[thread overview]
Message-ID: <20120515151050.GA23916@kroah.com> (raw)
In-Reply-To: <20120515143950.GA4654@debian.Jeff>

On Tue, May 15, 2012 at 08:09:50PM +0530, Jeffrin Jose wrote:
> hello ,
> 
> worked on styling fixes in drivers/usb/storage/usb.c
> 
> 
> >From 67edcc16dffc6f05f8bad70590e4175b7aeaa945 Mon Sep 17 00:00:00 2001
> From: Jeffrin Jose <ahiliation@yahoo.co.in>
> Date: Tue, 15 May 2012 19:42:31 +0530
> Subject: [PATCH 2/2] drivers:Fixed several coding style issues in
>  drivers/usb/storage/usb.c

Please just use git send-email to send this, so I don't have to edit
out your "hello..." lines.

> 
> - Fixed trailing white space issues.
> - Fixed C99 comment issue.
> - Fixed keyword related space issues.
> in drivers/usb/storage/usb.c

You did 3 different things here, so please, make 3 different patches.
Remember, only do one thing at a time.

Care to redo this and resend these patches?

thanks,

greg k-h

      reply	other threads:[~2012-05-15 15:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 14:39 styling fixes in drivers/usb/storage/usb.c Jeffrin Jose
2012-05-15 15:10 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515151050.GA23916@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ahiliation@yahoo.co.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox