From: Gleb Natapov <gleb@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Hannes Reinecke <hare@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH] EDD: Check for correct EDD 3.0 length
Date: Tue, 15 May 2012 18:53:03 +0300 [thread overview]
Message-ID: <20120515155303.GJ6948@redhat.com> (raw)
In-Reply-To: <20120515164143.3e8a8d04@pyramind.ukuu.org.uk>
On Tue, May 15, 2012 at 04:41:43PM +0100, Alan Cox wrote:
> > Hmm, will work if standard I/O addresses are used for master/slave, but
> > I do not see this information be exposed via /sys by EDD. So how can I
> > do it from OS installer with current kernel or kernel with reverted
> > patch?
>
> I don't think we provide the needed info for this (or EDD 2.1 which I've
> just discovered actually shipped in some plug in boards). Not sure 2.1 is
> around online anywhere.
>
> Thats a separate problem though.
>
It is not. You are saying that the code we have now supported Phoenix
spec and now it is not. This is not the case though.
> My big concern is that we are sure it disappearing won't break anything.
> It's been noticed at SuSE so it's obviously not entiely invisible.
So lets ask Hannes what problem he tries to fix by the patch.
>
> I'd love to see EDD 1.1 and 2.1 support in the kernel as I could then
> merge pata_hdd which drives original MFM/RLL drives. However I don't
> believe its worth the effort unlike doing 3.0 right.
>
It is OK to add Phoenix support to the code. To do that code needs to
figure what spec BIOS uses and parse the data differently, not just blindly
misinterpret binary buffer.
--
Gleb.
next prev parent reply other threads:[~2012-05-15 15:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:04 [PATCH] EDD: Check for correct EDD 3.0 length Hannes Reinecke
2012-05-15 11:12 ` Gleb Natapov
2012-05-15 11:20 ` Hannes Reinecke
2012-05-15 11:59 ` Gleb Natapov
2012-05-15 12:53 ` Gleb Natapov
2012-05-15 13:49 ` Alan Cox
2012-05-15 14:12 ` Gleb Natapov
2012-05-15 14:18 ` Alan Cox
2012-05-15 14:21 ` Gleb Natapov
2012-05-15 14:36 ` Alan Cox
2012-05-15 14:48 ` Gleb Natapov
2012-05-15 14:54 ` Alan Cox
2012-05-15 15:00 ` Gleb Natapov
2012-05-15 14:00 ` Alan Cox
2012-05-15 14:36 ` Gleb Natapov
2012-05-15 14:52 ` Alan Cox
2012-05-15 14:53 ` Gleb Natapov
2012-05-15 15:22 ` Alan Cox
2012-05-15 15:29 ` Gleb Natapov
2012-05-15 15:41 ` Alan Cox
2012-05-15 15:53 ` Gleb Natapov [this message]
2012-05-15 15:14 ` Alan Cox
2012-05-15 15:31 ` Alan Cox
2012-05-15 15:46 ` Gleb Natapov
2012-05-15 17:17 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2012-05-16 6:51 Hannes Reinecke
2012-05-16 8:28 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515155303.GJ6948@redhat.com \
--to=gleb@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hare@suse.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox