Re: [PATCH] gpio: Emma Mobile GPIO driver

Arnd Bergmann
2012-05-15T19:13:32Z

On Tuesday 15 May 2012, Magnus Damm wrote:
> >> > Isn't there a new nice inline that will both request and
> >> > remap a piece of memory?
> >>
> >> If so then that would be excellent. Especially together with
> >> ioread/iowrite so the code can work both for IOMEM and PORT
> >> transparently.
> >
> > We have a bunch of helpers, but I think none that does
> > everything yet. io_iomap() locates and remaps the resource.
> > devm_request_and_ioremap() does the request and the map, but
> > doesn't pull it out of the device.
>
> Let me know if you see any reason for not doing that. I'd be happy to
> try to cook something up and convert my drivers one by one.

I think it would be good to have it, so I don't mind if you give it
a go, but I fear that a lot of people cna have conflicting ideas on
what the perfect interface looks like ;-)

Arnd