From: Andrew Lunn <andrew@lunn.ch>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Shubhrajyoti D <shubhrajyoti@ti.com>,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated
Date: Tue, 15 May 2012 21:58:01 +0200 [thread overview]
Message-ID: <20120515195801.GE23254@lunn.ch> (raw)
In-Reply-To: <20120511032455.6BB853E04A6@localhost>
On Thu, May 10, 2012 at 09:24:55PM -0600, Grant Likely wrote:
> On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D <shubhrajyoti@ti.com> wrote:
> >
> > > Currently the prepare/unprepare transfer are called unconditionally.
> > > The assumption is that every driver using the spi core queue infrastructure
> > > has to populate the prepare and unprepare functions. This encourages
> > > drivers to populate empty functions to prevent crashing.
> > > This patch prevents the call to prepare/unprepare if not populated.
> > >
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> >
> > Great!
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Applied, thanks (after fixing extra whitespace defect).
Hi Grant
Is this going to appear in linux-next soon? Can i depend on having
this patch for 3.5?
Thanks
Andrew
next prev parent reply other threads:[~2012-05-15 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:50 [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated Shubhrajyoti D
2012-05-10 14:01 ` Linus Walleij
2012-05-11 3:24 ` Grant Likely
2012-05-15 19:58 ` Andrew Lunn [this message]
2012-05-20 5:00 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515195801.GE23254@lunn.ch \
--to=andrew@lunn.ch \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox