From: Josh Cartwright <joshc@linux.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH -rt] mm: protect activate_mm() by preempt_[disable|enable]_rt()
Date: Tue, 15 May 2012 17:36:19 -0400 [thread overview]
Message-ID: <20120515213619.GA8880@joshcartwright.net> (raw)
In-Reply-To: <1337061236-1766-1-git-send-email-yong.zhang0@gmail.com>
On Tue, May 15, 2012 at 01:53:56PM +0800, Yong Zhang wrote:
> From: Yong Zhang <yong.zhang@windriver.com>
>
> Otherwise there will be warning on ARM like below:
>
> WARNING: at build/linux/kernel/smp.c:459 smp_call_function_many+0x98/0x264()
> Modules linked in:
> [<c0013bb4>] (unwind_backtrace+0x0/0xe4) from [<c001be94>] (warn_slowpath_common+0x4c/0x64)
> [<c001be94>] (warn_slowpath_common+0x4c/0x64) from [<c001bec4>] (warn_slowpath_null+0x18/0x1c)
> [<c001bec4>] (warn_slowpath_null+0x18/0x1c) from [<c0053ff8>](smp_call_function_many+0x98/0x264)
> [<c0053ff8>] (smp_call_function_many+0x98/0x264) from [<c0054364>] (smp_call_function+0x44/0x6c)
> [<c0054364>] (smp_call_function+0x44/0x6c) from [<c0017d50>] (__new_context+0xbc/0x124)
> [<c0017d50>] (__new_context+0xbc/0x124) from [<c009e49c>] (flush_old_exec+0x460/0x5e4)
> [<c009e49c>] (flush_old_exec+0x460/0x5e4) from [<c00d61ac>] (load_elf_binary+0x2e0/0x11ac)
> [<c00d61ac>] (load_elf_binary+0x2e0/0x11ac) from [<c009d060>] (search_binary_handler+0x94/0x2a4)
> [<c009d060>] (search_binary_handler+0x94/0x2a4) from [<c009e8fc>] (do_execve+0x254/0x364)
> [<c009e8fc>] (do_execve+0x254/0x364) from [<c0010e84>] (sys_execve+0x34/0x54)
> [<c0010e84>] (sys_execve+0x34/0x54) from [<c000da00>] (ret_fast_syscall+0x0/0x30)
> ---[ end trace 0000000000000002 ]---
>
> The reason is that ARM need irq enabled when doing activate_mm().
> According to mm-protect-activate-switch-mm.patch, actually
> preempt_[disable|enable]_rt() is sufficient.
Frank Rowand posted a very similar fix in December of last year that
we've been carrying to fix the same issue:
http://permalink.gmane.org/gmane.linux.kernel/1229806
It looks like there was some deliberation as to whether or not it should
be pulled into stable-rt. Perhaps its time to revisit this discussion?
--
joshc
next prev parent reply other threads:[~2012-05-15 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 5:53 [PATCH -rt] mm: protect activate_mm() by preempt_[disable|enable]_rt() Yong Zhang
2012-05-15 21:36 ` Josh Cartwright [this message]
2012-05-16 1:38 ` Yong Zhang
2012-05-16 1:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515213619.GA8880@joshcartwright.net \
--to=joshc@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).