public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xudong Hao <xudong.hao@linux.intel.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	haitao.shan@intel.com, xiantao.zhang@intel.com,
	xudong.hao@intel.com
Subject: [PATCH 4/4] Enabling Access bit when doing memory swapping
Date: Wed, 16 May 2012 09:12:30 +0800	[thread overview]
Message-ID: <20120516011230.GE14256@hp-xd.sh.intel.com> (raw)

Enabling Access bit when doing memory swapping.

Signed-off-by: Haitao Shan <haitao.shan@intel.com>
Signed-off-by: Xudong Hao <xudong.hao@intel.com>
---
 arch/x86/kvm/mmu.c |   13 +++++++------
 arch/x86/kvm/vmx.c |    6 ++++--
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index ff053ca..5f55f98 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -1166,7 +1166,8 @@ static int kvm_age_rmapp(struct kvm *kvm, unsigned long *rmapp,
    int young = 0;

    /*
-    * Emulate the accessed bit for EPT, by checking if this page has
+    * In case of absence of EPT Access and Dirty Bits supports,
+    * emulate the accessed bit for EPT, by checking if this page has
     * an EPT mapping, and clearing it if it does. On the next access,
     * a new EPT mapping will be established.
     * This has some overhead, but not as much as the cost of swapping
@@ -1179,11 +1180,11 @@ static int kvm_age_rmapp(struct kvm *kvm, unsigned long *rmapp,
    while (spte) {
        int _young;
        u64 _spte = *spte;
-       BUG_ON(!(_spte & PT_PRESENT_MASK));
-       _young = _spte & PT_ACCESSED_MASK;
+       BUG_ON(!is_shadow_present_pte(_spte));
+       _young = _spte & shadow_accessed_mask;
        if (_young) {
            young = 1;
-           clear_bit(PT_ACCESSED_SHIFT, (unsigned long *)spte);
+           *spte &= ~shadow_accessed_mask;
        }
        spte = rmap_next(rmapp, spte);
    }
@@ -1207,8 +1208,8 @@ static int kvm_test_age_rmapp(struct kvm *kvm, unsigned long *rmapp,
    spte = rmap_next(rmapp, NULL);
    while (spte) {
        u64 _spte = *spte;
-       BUG_ON(!(_spte & PT_PRESENT_MASK));
-       young = _spte & PT_ACCESSED_MASK;
+       BUG_ON(!is_shadow_present_pte(_spte));
+       young = _spte & shadow_accessed_mask;
        if (young) {
            young = 1;
            break;
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 89151a9..a3ef549 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -7242,8 +7242,10 @@ static int __init vmx_init(void)
    vmx_disable_intercept_for_msr(MSR_IA32_SYSENTER_EIP, false);

    if (enable_ept) {
-       kvm_mmu_set_mask_ptes(0ull, 0ull, 0ull, 0ull,
-               VMX_EPT_EXECUTABLE_MASK);
+       kvm_mmu_set_mask_ptes(0ull,
+           (enable_ept_ad_bits) ? VMX_EPT_ACCESS_BIT : 0ull,
+           (enable_ept_ad_bits) ? VMX_EPT_DIRTY_BIT : 0ull,
+           0ull, VMX_EPT_EXECUTABLE_MASK);
        ept_set_mmio_spte_mask();
        kvm_enable_tdp();
    } else
--
1.7.1


             reply	other threads:[~2012-05-16  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16  1:12 Xudong Hao [this message]
2012-05-18  2:22 ` [PATCH 4/4] Enabling Access bit when doing memory swapping Marcelo Tosatti
2012-05-21  3:22   ` Hao, Xudong
2012-05-21  8:31     ` Avi Kivity
2012-05-21 10:35       ` Hao, Xudong
2012-05-21 10:48         ` Avi Kivity
2012-05-21 11:17           ` Hao, Xudong
2012-05-21 11:31             ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120516011230.GE14256@hp-xd.sh.intel.com \
    --to=xudong.hao@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=haitao.shan@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiantao.zhang@intel.com \
    --cc=xudong.hao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox