From: Stephen Hemminger <shemminger@vyatta.com>
To: "Andrew Stiegmann (stieg)" <astiegmann@vmware.com>
Cc: linux-kernel@vger.kernel.org, acking@vmware.com, dtor@vmware.com,
gregkh@linuxfoundation.org,
virtualization@lists.linux-foundation.org, dsouders@vmware.com,
akpm@linux-foundation.org, cschamp@vmware.com
Subject: Re: [vmw_vmci RFC 01/11] Apply VMCI context code
Date: Wed, 16 May 2012 10:01:21 -0700 [thread overview]
Message-ID: <20120516100121.3be6d0ca@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1337094428-20453-2-git-send-email-astiegmann@vmware.com>
On Tue, 15 May 2012 08:06:58 -0700
"Andrew Stiegmann (stieg)" <astiegmann@vmware.com> wrote:
> Context code maintains state for vmci and allows the driver
> to communicate with multiple VMs.
>
> Signed-off-by: Andrew Stiegmann (stieg) <astiegmann@vmware.com>
Running checkpatch reveals the usual noise, and the following that
should be addressed.
ERROR: do not use C99 // comments
#272: FILE: drivers/misc/vmw_vmci/vmci_context.c:183:
+static bool ctx_exists_locked(uint32_t cid) // IN
ERROR: "foo * bar" should be "foo *bar"
#304: FILE: drivers/misc/vmw_vmci/vmci_context.c:215:
+ uid_t * user, struct vmci_ctx **outContext)
I don't mind the C99 style comments, but the // IN convention
is pretty useless and should be removed.
next prev parent reply other threads:[~2012-05-16 17:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:06 [vmw_vmci RFC 00/11] VMCI for Linux Andrew Stiegmann (stieg)
2012-05-15 15:06 ` [vmw_vmci RFC 01/11] Apply VMCI context code Andrew Stiegmann (stieg)
2012-05-15 23:47 ` Greg KH
2012-05-16 17:01 ` Stephen Hemminger [this message]
2012-05-16 18:34 ` Andrew Stiegmann
2012-05-15 15:06 ` [vmw_vmci RFC 02/11] Apply VMCI datagram code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 03/11] Apply VMCI doorbell code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 04/11] Apply VMCI driver code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 05/11] Apply VMCI event code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 06/11] Apply dynamic array code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 07/11] Apply VMCI hash table Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 08/11] Apply VMCI queue pairs Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 09/11] Apply VMCI resource code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 10/11] Apply vmci routing code Andrew Stiegmann (stieg)
2012-05-15 15:07 ` [vmw_vmci RFC 11/11] Apply the header code to make VMCI build Andrew Stiegmann (stieg)
2012-05-15 23:50 ` [vmw_vmci RFC 00/11] VMCI for Linux Greg KH
2012-05-16 8:55 ` Dor Laor
2012-06-01 15:33 ` Andy King
2012-06-04 22:57 ` Greg KH
2012-06-05 7:02 ` Dmitry Torokhov
2012-06-06 5:06 ` Greg KH
2012-06-14 11:52 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516100121.3be6d0ca@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=acking@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=astiegmann@vmware.com \
--cc=cschamp@vmware.com \
--cc=dsouders@vmware.com \
--cc=dtor@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox